Supplementaries

Supplementaries

110M Downloads

[1.19.2] Unexpected hotbar lockup with the Quiver and GUIs.

zaeonNineZero opened this issue ยท 2 comments

commented

Versions
Supplementaries 2.3.19 for Minecraft 1.19.2. Loader is Forge 43.2.6.
Forge 1.20.1 versions of Supplementaries may also have this issue but have not been tested for it.

The Issue
The hotbar locks up - preventing you from switching slots via the mouse wheel or number keys - if the Quiver keybind is held while a GUI such the pause menu or inventory is opened, then released before closing the GUI.

To Reproduce
The simplest way to reproduce the issue is to hold the Quiver keybind and open the pause menu, release the keybind, then close the pause menu. The hotbar will then be locked up. Upon pressing and releasing the Quiver keybind again, the hotbar will unlock and work as expected. This method also works with all other GUIs in the game, included modded ones.

If the Quiver is in the inventory or a valid slot when performing the above sequence, the Quiver's selection GUI will stay up until the keybind is pressed and released again.

Thoughts
To me, it looks as though the keybind handler fails to recognize that the Quiver key is not being held after closing an inventory, and doesn't properly update until the key is pressed again. There also appears to be no check for whether there is a Quiver in the inventory or a valid slot before locking the hotbar and running the Quiver slot selection code.

commented

I'll have a look

commented

Confirmed fixed on 1.19.2-2.3.20. Thanks!