In GitLab by @KingCobra_200 on Dec 1, 2020, 18:20

Merges master -> master

Closes issues #29 #20 and #14

Kill it instead. Don't force remove it, then you won't need to catch the exception.

Enforce this as HunterEntity type.

It should not be accessible in this way. The add and remove methods allow us to conntrol it. Is this really needed?

For the same reasons in regards to access, an ImmutableList#of(hunterUUIDs) should be used here. This will mean you can only read the values.

Should be translatable

Should be translatable

Should be translatable

Not needed?

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:31

Commented on src/main/java/com/convallyria/taleofkingdoms/client/gui/entity/GuildMasterScreen.java line 112

changed this line in version 2 of the diff

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:31

Commented on src/main/java/com/convallyria/taleofkingdoms/common/world/ClientConquestInstance.java line 82

changed this line in version 2 of the diff

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:31

Commented on src/main/java/com/convallyria/taleofkingdoms/client/gui/entity/GuildMasterScreen.java line 115

changed this line in version 2 of the diff

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:31

Commented on src/main/java/com/convallyria/taleofkingdoms/client/gui/entity/GuildMasterScreen.java line 111

changed this line in version 2 of the diff

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:31

Commented on src/main/java/com/convallyria/taleofkingdoms/client/gui/entity/GuildMasterScreen.java line 108

changed this line in version 2 of the diff

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:31

Commented on src/main/java/com/convallyria/taleofkingdoms/client/gui/entity/GuildMasterScreen.java line 92

changed this line in version 2 of the diff

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:31

added 1 commit

• efd2b77 - Fixed translations, still troubleshooting retire hunter.

Compare with previous version

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:57

Commented on src/main/java/com/convallyria/taleofkingdoms/common/world/ClientConquestInstance.java line 68

changed this line in version 3 of the diff

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:57

added 1 commit

• 713fe84 - Retire Hunter troubleshooting.

Compare with previous version

In GitLab by @KingCobra_200 on Dec 24, 2020, 16:25

added 1 commit

• 7bdc515 - Retire Hunter button working.

Compare with previous version

In GitLab by @KingCobra_200 on Dec 24, 2020, 16:55

Commented on src/main/java/com/convallyria/taleofkingdoms/common/world/ClientConquestInstance.java line 73

changed this line in version 5 of the diff

In GitLab by @KingCobra_200 on Dec 24, 2020, 16:55

added 1 commit

• ccf8830 - Added ImmutableList for read access only.

Compare with previous version

resolved all threads

approved this merge request

requested review from @SamB440

mentioned in commit e84d566