Guild attack implementation - [merged]

Question

SamB440 opened this issue 4 years ago · 4 comments

SamB440 commented 4 years ago

Merges guild-attack -> master

This implements the guild attack and fixes lots of other bugs.

Signed-off-by: SamB440 [email protected]

SamB440 · Answer 1 · 2021-04-19T20:41:10.000Z

DeepCode's analysis on #44f44c found:

Description	Example fixes
Consider checking the presence of the optionals value with isPresent before accessing it with get Occurrences: GuildMasterEntity.java:87 GuildMasterEntity.java:168	🔧 Example fixes
Use getBlockState instead of getBlock. Occurrences: SellBlock.java:54 GatewayStructureProcessor.java:36 SellBlockEntity.java:46	🔧 Example fixes

SamB440 · Answer 2 · 2021-04-19T20:46:10.000Z

Not sure about all the additions here, but oh well!

SamB440 · Answer 3 · 2021-04-19T20:48:15.000Z

resolved all threads

SamB440 · Answer 4 · 2021-04-19T20:48:23.000Z

mentioned in commit 63d5855