[1.20.2 Development Build] Adding Console Patterns only works in tardis_refined namespace
dhi-holo opened this issue ยท 2 comments
Issue description
When attempting to test making a new console skin, I used the namespace tt_holo, just so it wouldn't be the default namespace, and it would be customised for myself. However, even with the json written below, it wasn't showing up in game. However, when I changed the datapack namespace to tardis_refined, it showed up immediately on /reload.
This is not the intended behaviour, according to the wiki page.
The exact datapack file paths are:
TT Holo [Datapack]\data\tt_holo\tardis_refined\patterns\console\toyota.json
TT Holo [Datapack]\data\tardis_refined\tardis_refined\patterns\console\toyota.json
The second one functions, the first does not. No other changes were made to the pack.
The json is
{
"patterns": [
{
"id": "tt_holo:wood",
"name_component": "{\"color\":\"yellow\",\"text\":\"Wood\"}",
"texture_definition": {
"emissive": true,
"texture": "tt_holo:textures/textures/blockentity/console/toyota/toyota_console_wood.png"
}
}
]
}Steps to reproduce
- Make a datapack which attempts to add new patterns to a console in a random valid namespace (such as
tt_holo) - Check if pattern exists in-game (the result should be that it does appear in-game)
- Change used namespace to
tardis_refined - Check if pattern exists in-game (the result here should always be that it does appear)
Minecraft version
1.19.2 (Latest)
Mod Loader Platform type
Fabric
Mod Loader version
Fabric Loader 0.15.1 (1.20.2)
Tardis Refined version
v1.0.1
Other relevant versions
1.20.2 Development Build, do not trust the Minecraft version field.
Attach the relevant crash report file or log file: (Don't know how to find a crash report file? See the Minecraft Wiki Tutorial
No response
Thanks for pointing this out dhi. The behaviour you described is now intended behaviour as of the 1.20 development. As part of #182 we changed pattern merging behaviour to act like vanilla tags, where all json file entries with the same namespace will be merged.
The previous behaviour where any namespace was allowed was misleading, because in the back end we would hardcode it to tardis_refined, meaning if you wanted to add a console pattern or shell pattern for a console/shell added by an addon mod, it would not be possible to do so.
The documentation on the wiki is user facing, intended only for publicly released builds. We will update the documentation in due time when the 1.20 version is released. :)