Taterzens [Fabric]

Taterzens [Fabric]

86.3k Downloads

Bug report [Forge / Fabric] speak_distance messages

ysefwakil opened this issue ยท 5 comments

commented

Describe the bug
A clear and concise description of what the bug is.

Platform(s)

  • Fabric
  • [] Forge

Environment(s)

  • [] Singleplayer
  • Server

Versions

  • Minecraft 1.19.2
  • Taterzens 1.11.1

To Reproduce
Steps to reproduce the behavior:

  1. Launch server '...'
  2. Run '....'
  3. Right-click '....'
  4. See error

Expected behavior
Ability to change speak_distance for messages

speak_distance is not changing. I am moving 10 blocks away and messages are not being sent to me

commented

This is true, I also experienced this.

The issue is in this piece of code. The problem that the box only gets inflated by 4.0, so the all the entities outside this box won't get captured and, as a result, receive a message - even if speak_distance in config is more than ~6.

I could PR a fix for this if that's okay @samolego

commented

Thanks for pointing it out!
I'm glad you're willing to help, though rn developing is ... stale. I don't wanna steal your time, as mod might take a long while to be released for the new version.

If you decide to do it anyway, please use rewrite/polymer as the base.
Currently the only issue there (which is pushing back the release) is gameprofiles not reloading (name changes, skin changes do not reflect the right state).

commented

I assume this issue should be closed now @samolego

commented

Even using: /taterzens config edit messages speakDistance 20
and then reloaded after that

tried creating a new npc as well, not working

If I am over 3 blocks I still don't get any messages

commented

Thanks for reporting, will test it when I have time