Incompatibility with Apotheosis 7.2.0
MrFastZombie opened this issue · 3 comments
Minecraft 1.20.1
Tax Free Levels 1.3.6
Apotheosis 7.2.0
NeoForge 47.1.84
Log: https://mclo.gs/VrIHx84
When Apotheosis and Tax Free Levels are installed together, there is a crash at start up that gives this error
[16:12:43] [pool-4-thread-1/FATAL] [mixin/]: Mixin apply failed taxfreelevels-forge.mixins.json:FlattenAnvilCostMixin -> net.minecraft.world.inventory.AnvilMenu: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Specified index 0 for @ModifyArg is invalid for args (Lnet/minecraft/world/entity/player/Player;I), expected I on net/minecraft/world/inventory/AnvilMenu::taxfreelevels$flattenAnvilCost [INJECT Applicator Phase -> taxfreelevels-forge.mixins.json:FlattenAnvilCostMixin -> Apply Injections -> -> Inject -> taxfreelevels-forge.mixins.json:FlattenAnvilCostMixin->@ModifyArg::taxfreelevels$flattenAnvilCost(I)I]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Specified index 0 for @ModifyArg is invalid for args (Lnet/minecraft/world/entity/player/Player;I), expected I on net/minecraft/world/inventory/AnvilMenu::taxfreelevels$flattenAnvilCost [INJECT Applicator Phase -> taxfreelevels-forge.mixins.json:FlattenAnvilCostMixin -> Apply Injections -> -> Inject -> taxfreelevels-forge.mixins.json:FlattenAnvilCostMixin->@ModifyArg::taxfreelevels$flattenAnvilCost(I)I]
I also saw this warning, no idea if it is related
[16:12:34.135] [main/WARN] [loading.FMLConfig/CORE]: Configuration file F:\Games\PolyMC Instances\Tax Free Levels - Apotheosis\.minecraft\config\fml.toml is not correct. Correcting
Aha, it looks like Apotheosis added their own "optimal cost" implementation!
It's different from mine, which bases the cost on level 30 instead of level 0, so it'll be drasticly cheaper for small original level costs.
Proper compatibility would require a change on Apotheosis' side, probably involving MixinExtras and I don't think anyone is really going to care for the difference, so I just disabled the conflicting mixin when both mods run together.
Also, just a heads up: NeoForge 1.20.1 isn't officially supported. You are using the Forge version, which just happens to be compatible. Forge 1.20.2+ mods will not be compatible with NeoForge 1.20.2+, so don't get too used to the idea of using NeoForge as a drop-in replacement for Forge.
(That said, I'll always support NeoForge.)
1.3.7 is up!
Actually, maybe I can change the implementation in their Placebo mod, no need to try to fix the mixin conflict!