Tax Free Levels (Fabric/(Neo)Forge)

Tax Free Levels (Fabric/(Neo)Forge)

2M Downloads

[1.20.x] Enchantment Infuser integration is broken... again?

lloyd-pinrun opened this issue ยท 5 comments

commented

Looks like this issue may have only been resolved for 1.21.x or that fix could have potentially broken the integration in 1.20.x?

Mod loader:
Fabric 0.16.10

Mod versions:

  • Tax Free Levels: 1.4.6
  • Enchantment Infuser: 8.0.3

Crash log:
https://mclo.gs/urZaUnf

Specifically:

Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @ModifyArg annotation on taxfreelevels$flattenRepairCost could not find any targets matching 'processEnchantingCost' or 'Lfuzs/enchantinginfuser/world/inventory/InfuserMenu;lambda$clickRepairButton$2(Lnet/minecraft/class_1657;Lnet/minecraft/class_1937;Lnet/minecraft/class_2338;)V' in fuzs/enchantinginfuser/world/inventory/InfuserMenu. Using refmap TaxFreeLevels-fabric-refmap.json [INJECT_PREPARE Applicator Phase -> taxfreelevels-fabric.mixins.json:EnchantingInfuserMixin from mod taxfreelevels

Let me know if there's anything more you need. I'm going to try reverting to the previous version of Tax Free Levels, and I'll let reply to this issue if that resolves the issue.

commented

Reverting to the previous version of Tax Free Levels (1.4.4) prevented the crash, so the change to resolve the issue with the integration with 1.21.x is likely the culprit ๐Ÿ•ต๏ธ

commented

Potentially this commit? 1221336

commented

Should be fixed in 1.4.7!
I replaced the compat with a general one that should work for all Enchantment Infuser versions, maybe even future ones.

commented

Ah, right, I forgot that this version was for both 1.21 and 1.20!

Wait no, I'm getting confused...

I just tested it on Forge 1.20.1 and it seems to work just fine, but it crashes on Fabric - is 8.0.3 actually different between the two platforms?

Ah, I got it, I accidentally backported the Fabric stuff when I had to redo the Dis-Enchanting Table compat merge. Easy fix.

commented

Awesome! Thanks!