[1.12] Industrial Grinder and Crafttweaker
tgstyle opened this issue ยท 12 comments
Trying to add a recipe with null for output stack 2-4 says output stack null or empty. Is this not possible? Input stack 2 as null works fine.
mods.techreborn.grinder.addRecipe(techreborn:dust:20 * 4, null, null, null, enderore:ore_ender, null, liquid:water, 20, 128);
those if checks need to make sure the stack isnt empty. But should still do a null check.
@drcrazy, nope, we get "Output stack should not be empty" when using minecraft:air.
@modmuss50 indeed. Should be something like:
if(output1 != null)
if(!output1.isItemEqual(ItemStack.EMPTY))
addOutput(output1);
if(output1 != null && !output1.isItemEqual(ItemStack.EMPTY))
is what needs to be done. If I get a chance it will only take 10 mins to fix.
The same here. Reason: CT returns ItemStack.EMPTY instead of null when null is passed in Zenscript. Should be pretty easy to fix:
I'm not a java guy, and have no idea - whether it is smart enough not to check second condition, if first one is already false, otherwise it is quite possible to get NPE ;) But you're the boss ;)
Guys, can you test CT support for Industrial Grinder, please?
Pick jenkins build here: https://jenkins.modmuss50.me/job/Team%20Reborn/job/TechReborn/job/1.12/208/artifact/build/libs/TechReborn-1.12.1-2.7.0.208-universal.jar
We've got crush here:
https://gist.github.com/ZigTheHedge/851a742253e809e974cb0a96be87a3dd