Tech Reborn

Tech Reborn

30M Downloads

[Suggestion]Use inputstack instead of output stack in MT machine recipe removal

wormzjl opened this issue ยท 19 comments

commented

centrifuge, electrolyzer...etc
This allows better control of recipes and can prevent accidental removal of other recipes.
And this is pretty much a standard for MT integrations in other mods.

commented

While testing with the latest version I still find it impossible to remove recipes with inputstack
However output stack still works?

commented

ok, thanks for that, I will take a look into it

commented

That should do it

commented

Umm it seems that it's still broken
I was testing with this
mods.techreborn.blastFurnace.removeRecipe(techreborn:dust:81);
mods.techreborn.blastFurnace.removeRecipe(techreborn:smallDust:82);

commented

ok thanks for the script, I will have a look into it

commented

What was the main issue with the old way?? it worked fine right??

commented

Im thinking of reverting it because I dont want to break existing scripts

commented

Using output stack will sometimes remove a bunch of recipes while unintended, and it's difficult to find stuff that are not present in all other recipes, it's just easier to control via inputstack

commented

Sometime I just don't know what I could remove accidentally

commented

Oh you want to check the input slots, not the output ones??

commented

Ummm yeah

commented

ahh, I was confused

commented

Sry for that :3

commented

I think Im going to rewrite the MT support to be easier to maintain.

commented

I guess that this is not completed yet?
While using my old script I got this:
ERROR: tic.zs:22 > a method available but none matches the parameters (minetweaker.item.IItemStack)
This is for removing the aluminium brass ingot recipe from the alloy furnance

commented

Every machine now has removeInputRecipe as well as removeRecipe

commented

ok thx

commented

Seems to be bugged still

Using the following expression:
mods.techreborn.alloySmelter.removeInputRecipe(techreborn:ingot:0);

I got this in the MT log:
ERROR: Error executing tic.zs: null
java.lang.NullPointerException
at techreborn.compat.minetweaker.MTGeneric.removeInputRecipe(MTGeneric.java:36)
at Tic.script(tic.zs:22)
at ZenMain.run(tic.zs)
at minetweaker.runtime.MTTweaker.load(MTTweaker.java:163)
at minetweaker.MineTweakerImplementationAPI.reload(MineTweakerImplementationAPI.java:656)
at minetweaker.MineTweakerImplementationAPI$1.execute(MineTweakerImplementationAPI.java:83)
at minetweaker.MineTweakerImplementationAPI$19.execute(MineTweakerImplementationAPI.java:642)
at minetweaker.mc1710.server.MCServer$MCCommand.func_71515_b(MCServer.java:124)
at net.minecraft.command.CommandHandler.func_71556_a(CommandHandler.java:94)
at net.minecraft.network.NetHandlerPlayServer.func_147361_d(NetHandlerPlayServer.java:739)
at net.minecraft.network.NetHandlerPlayServer.func_147354_a(NetHandlerPlayServer.java:718)
at net.minecraft.network.play.client.C01PacketChatMessage.func_148833_a(SourceFile:37)
at net.minecraft.network.play.client.C01PacketChatMessage.func_148833_a(SourceFile:9)
at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:212)
at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:165)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:659)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547)
at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:111)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:427)
at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)

commented

That should fix it ^^^