Tech Reborn

Tech Reborn

30M Downloads

Datapacks can't seem to override TR recipes

saltyseadoggo opened this issue · 1 comments

commented

Describe the bug
I am trying to make a datapack to make Tech Reborn compatible with Vanilla Tweaks' More Stairs tweak, which doubles the output of all staircase crafting recipes. I rooted around in the mod's jar file to copy the structure of its data/techreborn/recipes/crafting_table/storage_blocks directories, copying them all into the datapack and removing all of the files that weren't the staircase recipes. I them edited them all to change the count argument number from four to eight. This is how Vanilla Tweaks makes its changes to vanilla, and a method I have had success with for mods such as TerraformersMC's Cinderscapes and Terrestria.

This did not work: all of the staircase recipes yielded four staircases instead of the datapack's eight. I tried to move the recipes to a different namespace id, which still did not work, as didn't changing the recipes to input or output different, arbitrary items such as dirt. When I replaced stair in all of the recipe names with stairs, I was able to get some of the recipes, like aluminium stairs, to work, albeit with two recipes appearing in the recipe book, whilst others, like invar, copper and zinc stairs, did not work at all, and still outputted four staircases. This would imply that _any recipe using the names [metal]storage_block_stair does not work in any namespace. I cannot figure out why only some of the recipes work and others do not when they are given different names.

I would like you to take a look at the datapack provided below to see what may be wrong with it, and, if Tech Reborn is doing something to hinder its interpretation of datapacks, I would like to see this fixed. The ideal end goal here is for this datapack to be able to replace the existing staircase recipes, without more than one staircase recipe appearing for each staircase type in the recipe book.

Steps to Reproduce
Steps to reproduce the behavior:

  • Download this demo datapack: tr recipe override demo.zip
  • Place this datapack into the datapacks folder of any save, and boot up the save.
  • Attempt to craft any staircase added by Tech Reborn. The recipe outputs four staircases instead of the intended eight. ❌
  • Open the datapack, and move all of the recipes from data/techreborn/recipes/crafting_table/storage_blocks to data/minecraft/recipes.
  • Run /reload in the save, and try to craft the staircase again. It still outputs four staircases. ❌
  • Open the datapack once more, move the recipes back, and rename all of them to their current name with stairs instead of stair.
  • Run /reload in the save, and try to craft an aluminium staircase. Eight staircases are outputted, but the recipe book now has two aluminium staircase recipes. ❌
  • Try to craft a copper staircase. Only four staircases are outputted. ❌

Environment (please complete the following information with the version):

  • Minecraft: 1.16
  • Mod Loader: Fabric
commented

Can't reproduce.

I've changed 3 stairs recipes through datapack:
image

Each one with different amount of stairs as output
image

image

image