Tech Reborn

Tech Reborn

30M Downloads

[1.17] [FF API] Amount of fluids in tanks decreased in 81 times

pipich3 opened this issue ยท 1 comments

commented

Summary

Loading an old world with new fluid API makes all tanks to contains only 1/81 of fluids volume what that was in them before

Steps to Reproduce

  • load world on build 85
  • place standalone Industrial Tank Unit
  • fill it completely with Nitrogen (500 000 Mb)
  • save&quit world
  • switch to build 94
  • load world
  • check tank filled volume
  • tank contains 6172 + 68/81 Mb of Nitrogen instead of 500 000 Mb (1/81 part)

Environment

  • Minecraft: 1.17.1
  • Mod Loader: Fabric (CurseForge 0.180.1.3)
  • Fabric API: 0.37.2
  • RebornCore: 5.0.5-beta -> 5.0.6-beta (build 85 -> 94)
  • TechReborn: 5.0.5-beta -> 5.0.6-beta (build 85 -> 94)

Assumptions

It seems that current logic keeps a constant count of minor liquid units in tanks
but new API minor unit is 1/81 Mb instead of 1 Mb pre-migration
so the tank that had X Mb (X minor units) still contains X minor units (new minor units), but now the real volume is X * (1/81) Mb = X/81 Mb instead of X Mb

may be related to fd9d776

commented

Sorry about that, but this can't be fixed. Hopefully such unit changes won't happen again.