Tech Reborn

Tech Reborn

30M Downloads

ores not generating in BYG biomes in 1.18.1

Chuunkyz opened this issue ยท 10 comments

commented

ores from this mod are inexistant in byg biomes and all modded biomes using terrablender
however some other ores such as indrev or ae2 work

commented

I want this to be fixed in fabric itself.

commented

is anyone working on it ?

commented

duplicate of #2701

commented

not really a duplicate

commented

same issue impacts all 3 biome mod types. so it is.
theres a PR on MI git to fix it, but needs some work.
hopefully @Technici4n can sort and copy it here ;)

commented

quick fix for it is using this instead:
OVERWORLD(BiomeSelectors.foundInTheNether().negate().and(BiomeSelectors.foundInTheEnd().negate())),
at TargetDimension.java.

vanilla ONLY supports nether biome modification (it considers its nether biome as modifed uhh) so currently there's no way to do it properly, also recent fabric api pr makes ore generation totally inaccessible so not a way to go...

The problem with it is vanilla biome registries are hardcoded, not dynamic, but nether is dynamic.

commented

no, I just tested it and it totally disabled modded ore generation , even AE too, I guess you mean this : https://github.com/shartte/fabric/tree/move-biome-mods-into-server-ctor

yes I meant that. If it didn't work please post a message on the PR otherwise it can't possibly be fixed.

commented

There is an open fabric API PR to resolve this, if someone wants to help just go test that.

commented

no, I just tested it and it totally disabled modded ore generation , even AE too, I guess you mean this : https://github.com/shartte/fabric/tree/move-biome-mods-into-server-ctor

Modded biomes sometimes does not register their dimension and directly plugs into chunkgenerator / noises...

commented

New FAPI version fixes this :
image

A new world with
FAPI 0.46.3
BYG 1.3.5.8
TR beta 7