Rubber trees spawn in way too many modded biomes
StockiesLad opened this issue · 5 comments
Describe the bug
Rubber trees spawn everywhere, in so many biome mods where it clearly doesn't belong. It ruins some biomes like the Autumnal woods from traverse.
Steps to Reproduce
Install any biome mod and see the billions of rubber trees
Screenshots
N/A
Environment (please complete the following information with the version):
- Minecraft: 1.18.2
- Mod Loader: fabric 0.14.9
Logs
Not Needed
Solution
Two solutions here. Either make rubber trees change with biome colour, or restrict their spawning to only vanilla biomes.
Well if a large number of custom biomes are added, precisely how is that techreborn's fault? I have pretty much all of the biome mods, and I'd like it to be in vanilla forests for 2 reasons:
- You should actually need to explore, thus improving that domain.
- Rubber trees do more harm then good by spawning in modded biomes.
It should at least be a config to restrict spawning to vanilla biomes.
Feel free to put a PR in :)
.add(ModificationPhase.ADDITIONS, BiomeSelectors.tag(BiomeTags.IS_FOREST)
.or(BiomeSelectors.tag(BiomeTags.IS_TAIGA))
.or(BiomeSelectors.includeByKey(BiomeKeys.SWAMP)), rubberTreeModifier())`
Firstly, 1.18.2 is no longer supported for features.
Secondly, restricting the spawn to only vanilla biomes could have an opposite effect if a large number of custom biomes are added, in that they become too rare.
