Tech Reborn

Tech Reborn

Mods
34M Downloads

[Fabric 1.20.1] Incompatibility with Vic's Point Blank

MidniteCaffeine opened this issue ยท 1 comments

commented

Describe the bug
Tech Reborn villagers won't trade while also using Vic's Point Blank. The villager type added by Point Blank works fine though.

Steps to Reproduce
Attempting to trade with any TR villager while Point Blank is loaded. Removing it fixes the issue.

Environment (please complete the following information with the version):

  • Minecraft: 1.20.1, with latest version of PB for it, (1.9.6)
  • Mod Loader: Fabric

Personally I just opted to use TacZ instead, but I thought I'd make this known in case it could possibly be fixed on your end, even though I get the feeling the issue comes from Point Blank (and as far as I could tell, they don't provide anywhere to report bugs so that's why I'm here instead)

commented

This is not a TechReborn issue.

This happens because the transaction list is cleared:
Image
Vic's Point Blank relies on VANILLA_TRADES when dealing with villagers:
Image
VANILLA_TRADES is just a snapshot initialized in static:
Image

The initialization order will affect the results:

No errors:

  • TechReborn onInitialize -> Vic's Point Blank static init -> Vic's Point Blank Events SERVER_STARTING
  • Vic's Point Blank static init -> Vic's Point Blank Events SERVER_STARTING -> TechReborn onInitialize

Has errors:

  • Vic's Point Blank static init -> TechReborn onInitialize -> Vic's Point Blank Events SERVER_STARTING