NPE crashing the game
burdoto opened this issue ยท 4 comments
Describe the bug
An internal NPE causes game crashes
Steps to Reproduce
unsure
Environment (please complete the following information with the version):
- Minecraft: 1.20.1
- Mod Loader: fabric
Additional context
I wrongly tried to adress this issue in #3425 in a hurry, but actually my attempt was wrong.
I am not entirely sure what causes this crash, as the previous block already checks for null.
@ZurrTum not entirely sure what you mean by that, my fix attempt was wrong, and how I see it, targets should never be null at that point
Have you tried the least mod for testing?
Although I don't know what caused it. But to solve NPE, you only need to replace it with isEmpty() and clear()
sorry, not fixed to my knowledge.
didnt know the paste had a timeout
here is the crashlog file:
https://paste.kescher.at/?8d6bb545f850caca#HzMcUwUoPPWso2ZRvkugXbXwUfx1doiU83aXZG9X4UEk
and as an attachment for good measure:
crash-2025-04-29_07.43.29-server.txt
also have to emphasize that i still dont know what caused this or how to reproduce it, so if this is the only instance of it being reported, that may have been a fluke
although the code in that mentioned PR does look quite off to me personally, i couldn't exactly fix it