Server Crash
parcel31u opened this issue · 38 comments
Yeah, looks like a holoInventory issue, report it to them, it might have something to do with us though. @dries007 any ideas?
No @ProfessorProspector its not. My first guess its because this mod (or some other mod in the pack) is using null for something it should be using null for. I'll look into it.
@parcel31u Do you happen to know what Item causes this?
The contents of the inventory your looking at gets turned into NBT, send to the client and decoded, just like for example chests, but I don't handle null itemstacks on the client side, since they are filtered out on the server side, before sending to the client.
The error occurs because ItemStack.loadItemStackFromNBT(tag);
is returning null, which should only be possible if Item.getItemById(tag.getShort("id"))
returns null, which suggests a discrepancy in the id<>item map, which should be impossible...
@dries007 Specifically looking at the diesel generator from techreborn.
@parcel31u how do you have set them up? Its been forever since I played with IC², so I don't know how it all works anymore :p
diesel generator is like combustion egine from buildcraft or biogas engine from forestry just for eu and maybe rf
but if I put one down, no IC² cables connect to it, and if I put in fuel it does nothing at all?
the cable stuff belongs to mc multipart, but he is waiting for forge if they revert their event stuff or not
You need MC multipart for the cables to work there is a tooltip on cables saying this
will.make no diff forge has work to be done on it still and forge will be updating to 1.9.1 soon
@gigabit101 I disagree
https://dries007.net/screenshots/2016-03-29_18-55-06.png
Also, we are talking about 1.7.10 here, since Holoinventory is 1.7.10 only
well the mod was not finished back then so try using the cables from TR as the RF config might be on
Because I did not make this issue.
Shouldn't it fill up its internal buffer regardless of if I put on cables or not?
https://dries007.net/screenshots/2016-03-29_19-00-35.png
But how is this person crashing then?
@parcel31u do you know what items where in the slots of the generator?
doesn't seem to be much since bakermanlp uses techreborn in his project RET series and this is 1.7.10
I guess I need more information, but it seems to mee like a bug in your code (or a strange interaction). I can see if I can build in some protection in HoloInventory.
ps: Just a friendly note: Treating the github issue tracker like an IRC channel with quick, gibberish, incomprehensible comments and memes is not going to make others eager to help or respond.
it wasnt supposed to be offensive, it just fit into modmuss "shall i close it" sentence