Tech Reborn

Tech Reborn

30M Downloads

Server Crash

parcel31u opened this issue · 38 comments

commented

Looks like a HoloInventory issue?
image

commented

Yeah, looks like a holoInventory issue, report it to them, it might have something to do with us though. @dries007 any ideas?

commented

Isn't holoinventory a clientside mod?

commented

No @ProfessorProspector its not. My first guess its because this mod (or some other mod in the pack) is using null for something it should be using null for. I'll look into it.

commented

@parcel31u Do you happen to know what Item causes this?

The contents of the inventory your looking at gets turned into NBT, send to the client and decoded, just like for example chests, but I don't handle null itemstacks on the client side, since they are filtered out on the server side, before sending to the client.

The error occurs because ItemStack.loadItemStackFromNBT(tag); is returning null, which should only be possible if Item.getItemById(tag.getShort("id")) returns null, which suggests a discrepancy in the id<>item map, which should be impossible...

commented

@dries007 Specifically looking at the diesel generator from techreborn.

commented

@parcel31u how do you have set them up? Its been forever since I played with IC², so I don't know how it all works anymore :p

commented

diesel generator is like combustion egine from buildcraft or biogas engine from forestry just for eu and maybe rf

commented

but if I put one down, no IC² cables connect to it, and if I put in fuel it does nothing at all?

commented

the cable stuff belongs to mc multipart, but he is waiting for forge if they revert their event stuff or not

commented

You need MC multipart for the cables to work there is a tooltip on cables saying this

commented

as soon as it is merged into forge this will not be a issue

commented

he should give them his code so its faster for us available

commented

will.make no diff forge has work to be done on it still and forge will be updating to 1.9.1 soon

commented

leaks?

commented

no it has already been said after the re factor they wanted to move to 1.9.1

commented

also basic logic applies here as well

commented

@gigabit101 I disagree
https://dries007.net/screenshots/2016-03-29_18-55-06.png

Also, we are talking about 1.7.10 here, since Holoinventory is 1.7.10 only

commented

you are using 1.7 why did you not say that

commented

well the mod was not finished back then so try using the cables from TR as the RF config might be on

commented

Because I did not make this issue.
Shouldn't it fill up its internal buffer regardless of if I put on cables or not?
https://dries007.net/screenshots/2016-03-29_19-00-35.png

commented

true

commented

it should do yes

commented

... It might have just not been finished at that point

commented

But how is this person crashing then?
@parcel31u do you know what items where in the slots of the generator?

commented

I don't remember what was broken in that version

commented

doesn't seem to be much since bakermanlp uses techreborn in his project RET series and this is 1.7.10

commented

well good 2 know

commented

wrong button lol

commented

I didnt even click the button

commented

omg the email spamm

commented

lol

commented

Is there something to fix, or shall I close it?

commented

Its 1.7 and I don't think its ares

commented

I guess I need more information, but it seems to mee like a bug in your code (or a strange interaction). I can see if I can build in some protection in HoloInventory.

ps: Just a friendly note: Treating the github issue tracker like an IRC channel with quick, gibberish, incomprehensible comments and memes is not going to make others eager to help or respond.

commented

it wasnt supposed to be offensive, it just fit into modmuss "shall i close it" sentence

commented

I know, its not offensive, but it's not very professional. Its also a bunch of email spam again 📧