Tech Reborn

Tech Reborn

30M Downloads

1.10.2 - TCon and TechReborn Crash

Peach774 opened this issue ยท 7 comments

commented

1.10.2 LAN - Scrolling through the tinkers construct creative menu and reachieved this crash, since it mentions both tech reborn and tinkers construct I will also be posting this on their github.
http://pastebin.com/8mg4bckf

commented

Working fine in 1.10.2, please test again and open another issue

commented

You might still want to fix the check here so if you do accidentally oredict a wrong number again it does not crash. Right now it would cause a similar crash if you were to give your self a storage block with a metadata of 14

commented

I think I fixed this a while ago, it hasn't been brought to my attention recently so closing.

commented

This issue is twofold. First is what causes the crash, that being an off by one error in getStateFromMeta(). This check should use >= and not >.

Second is the fact that an invalid block is being oredicted. Metadata 14 is invalid according to the block class but is registered as "Iridium", which Tinkers construct pulled from the oredict for its automatic table textures. Metadata 13 where it should be is instead registered as "Osmium"

commented

Any sort of update on this issue? Still causing crashes.

commented

@modmuss50 either add more types here: https://github.com/TechReborn/TechReborn/blob/1.10/src/main/java/techreborn/blocks/BlockStorage.java#L27 or remove the Osmium from the oreDict here:

OreDictionary.registerOre("blockOsmium", new ItemStack(storage, 1, 13));

commented

I'm not at a pc for the next 3 weeks. Someone will have to PR in the fix it you will need to wait.

Sorry