Various bugs (I can fix some of them, too)
ThexXTURBOXx opened this issue ยท 13 comments
Hello TechReborn-Dev-Team,
I have some obvious bugs (I will fix some of them myself and create a PR. If you don't want my help, then just close the PR):
- Much textures missing: http://imgur.com/kgZSNu2 (Fixing in progress)
- Some names missing
- JEI showing ambigious recipes for cells (if you look after the e.g. Wolframium Cell, then it shows the recipes for EVERY cell, same thing happens with all cells): http://imgur.com/Bby1T1v (Fixed in JEI 3.7.9)
- OreDictionary-Entries of the Cells let the Informationbox (if you hover over them) explode (See here: http://imgur.com/mVyF32s)
- In ores.hjson-configfile: Typo ==> Tungston Ore
Now in Detail:
Textures missing for those:
TODO (Please someone else make them):
- Fluid Sulfur
- Fluid Sodium Sulfide
- Fluid Nitro Diesel
- Fluid Nitro Carbon
- Fluid Carbon Fiber
- Fluid Sulfuric Acid
- Fluid Diesel
- Fluid Carbon
- Fluid Oil
Already pushed:
- Diamond Jackhammer
- Diamond Saw Blade
- Superconductor
- Frequency Transmitter
- EV Transformer
- Battery
- Silicon Ingot
- Small Pile of Andesite Dust
- Small Pile of Diorite Dust
- Small Pile of Granite Dust
- Lazurite Plate
- Ruby Plate
- Sapphire Plate
- Peridot Plate
- Red Garnet Plate
- Yellow Garnet Plate
- Refined Iron Plate
- Advanced Alloy (Plate version)
- Hot Tungstensteel Nugget
- Tungstensteel Nugget
- Refined Iron Nugget
- Diamond Nugget
Translation Missing:
- fluid.fluidSulfur
- fluid.fluidsodiumSulfide
- fluid.fluidnitrodiesel
- fluid.fluidnitrocarbon
- fluid.fluidcarbonfiber
- fluid.fluidsulfuricacid
- fluid.fluiddiesel
- fluid.fluidcarbon
- fluid.fluidoil
- tile.techreborn.evtransformer.name
- item.techreborn.ingot.silicon.name
- item.techreborn.dust.obsidian.name
- item.techreborn.plate.Ruby.name
- item.techreborn.plate.Sapphire.name
- item.techreborn.plate.Peridot.name
- item.techreborn.plate.RedGarnet.name
- item.techreborn.plate.YellowGarnet.name
The issue with the information-box is there, because of any other mod. I think it is WAWLA, but I don't know... Anything is making it explode ;D
ores.hjson should be that as its using https://hjson.org/
May I go ahead and fix the lang-files and maybe some textures (if there are just some typos)? If you want, I could make some textures for some Items/Fluids.
Go for it, just open a PR. This was closed as it contained loads issues in one issue.
1 question: There is a ruby plate ingame, but in the ItemPlates-class is no ruby-plate in the types[]-array. How could this be? o_O
Same thing with Sapphire, Peridot, Red Garnet, Yellow Garnet and Refined Iron btw
Forget about it :) Didn't read the comments in the code :)
@mezz Could you please take a look at the JEI-recipe-bug (The 4th checkbox)? I don't know how to fix it and I think, that it has high priority...
The JEI issue should be solved by this commit: mezz/JustEnoughItems@9835032
It will automatically detect fluid in the items and differentiate them that way by default.
This is added in JEI 3.7.9
You need to register your item with the ISubtypeRegistry to tell JEI how to interpret its NBT.
However, this is such a common issue that I am probably going to use the fluid capabilities on items to differentiate them automatically, no need to make everyone implement the same thing on their fluid container items.