TenshiLib

TenshiLib

2M Downloads

TenshiLib can cause successful commands to show nothing or cause server lockup

Kaleidio opened this issue ยท 3 comments

commented

Modloader

Forge

Minecraft version

1.16.5

Modloader version

36.2.39

Mod version

1.3.0

Description

We had been dealing with this issue for a couple months now, to find that adding Zombie Awareness and CoroUtil made it worse. Initially it would just cause commands to show nothing in the console (a successful Locate command, or a successful Summon command, only on certain world seeds)

After doing mod searchthroughs I discovered this mod was left behind as "residue" when removing several other mods. Removing this mod only fixes all the issues we had been having.

Worst case scenario, with Zombie Awareness, Overworld Two, and BYG, you can cause the server to lockup simply by locating or generating a village chunk.

Steps to reproduce

  1. Install TenshiLib, Zombie Awareness, CoroUtil, BYG, Overworld Two, Roadrunner
  2. Generate an Overworld Two world with this seed for easy example: -2887856331656635266
  3. Summon a skeleton and witness the console return nothing
  4. Locate a village and witness the console return nothing, or in the worst case, lockup the internal server and place the client in a "desync" state.

Mods that might affect the issue

CoroUtil, Overworld Two, Roadrunner, all change things in algorithms that TenshiLib also does (sorted list for example, as noted in your 1.16.5 branch)

This can cause conflicts with how certain commands work, especially NBT random tables (summon command, structure nbt loading), and Structure locators (locate command)

Logs

Irrelevant, the log tells no errors.

commented

okay, I can confirm it's Tax Ocean Villager, not TenshiLib at fault for the commands returning nothing.

commented

Note that I'm not expecting any fixes for this old version, but I have been quite frustrated trying to find the cause for quite a while now. In fact this is only after a sprint of investigation of two weeks, and still might be incorrect.

commented

Okay, from what I can tell, another mod known as Tax Ocean Villagers needs to be installed to cause the issue. I am going to whittle down the modlist to check it is just these two alone or not