Terra (Fabric/Forge/Paper)

Terra (Fabric/Forge/Paper)

74.2k Downloads

[Bug] Out of bounds exception when using the compat.yml on 1.17

DUDEbehindDUDE opened this issue ยท 0 comments

commented

Pre-Issue Checklist

  • I have checked that I am on the latest version of Terra.
  • I have searched the github issue tracker for similar issues, including closed ones.
  • I have made sure that this is not a bug with another mod or plugin, and it is Terra that is causing the issue.
  • I have checked that this is an issue with Terra and not an issue with the pack I am using.
  • I have attached a copy of the latest.log file
  • I have filled out and provided all the appropriate information.

Environment

Name Value
Terra Version 5.3.3
Platform / Platform Version Fabric 1.17
Any External Plugins or Mods None
Terra Packs In Use default with the compat pack.yml
Terra Addons In Use None

Issue Description

When vanilla: structures is set to true in the pack.yml file an out of bounds exception occurs during the generation of the world

Steps to reproduce

  1. launch terra on 1.17 fabric
  2. unzip the default pack and edit the pack.yml to the compatability one
  3. launch terra again on a fresh world and as it's generating the world/when you go into new chunks at some point during generation it will crash with an out of bounds exception

Expected behavior

server shouldn't crash lol

Actual behavior

the server crashes
my guess is that some structure/feature generating is what causes this crash

Full stacktrace

Exception Stacktrace
[13:36:05] [Worker-Main-11/INFO]: Preparing spawn area: 51%
[13:36:05] [Worker-Main-12/WARN]: Worker-Main-12 died
java.util.concurrent.CompletionException: net.minecraft.class_148: Exception generating new chunk
	at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314) ~[?:?]
	at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319) ~[?:?]
	at java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1155) ~[?:?]
	at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:478) ~[?:?]
	at net.minecraft.class_3900.method_17634(class_3900.java:58) ~[intermediary-server.jar:?]
	at net.minecraft.class_3846.method_16907(class_3846.java:91) ~[intermediary-server.jar:?]
	at net.minecraft.class_3846.method_16900(class_3846.java:131) ~[intermediary-server.jar:?]
	at net.minecraft.class_3846.run(class_3846.java:99) ~[intermediary-server.jar:?]
	at java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1434) ~[?:?]
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:295) ~[?:?]
	at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1016) ~[?:?]
	at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1665) ~[?:?]
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1598) ~[?:?]
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183) [?:?]
Caused by: net.minecraft.class_148: Exception generating new chunk
	at net.minecraft.class_3898.method_17225(class_3898.java:567) ~[intermediary-server.jar:?]
	at com.mojang.datafixers.util.Either$Left.map(Either.java:38) ~[intermediary-server.jar:?]
	at net.minecraft.class_3898.method_17224(class_3898.java:549) ~[intermediary-server.jar:?]
	at java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1146) ~[?:?]
	... 11 more
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 256 out of bounds for length 256
	at com.dfsek.terra.fabric.generation.FabricChunkGeneratorWrapper.method_26261(FabricChunkGeneratorWrapper.java:183) ~[Terra-fabric-5.3.3-BETA+6027c282-shaded-mapped.jar:?]
	at net.minecraft.class_5183.method_27205(class_5183.java:175) ~[intermediary-server.jar:?]
	at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) ~[?:?]
	at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948) ~[?:?]
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) ~[?:?]
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) ~[?:?]
	at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913) ~[?:?]
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
	at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) ~[?:?]
	at net.minecraft.class_5183.method_27211(class_5183.java:175) ~[intermediary-server.jar:?]
	at net.minecraft.class_5183$class_5184.method_28646(class_5183.java:123) ~[intermediary-server.jar:?]
	at net.minecraft.class_5183$class_5184.method_16655(class_5183.java:61) ~[intermediary-server.jar:?]
	at net.minecraft.class_3195.method_28657(class_3195.java:269) ~[intermediary-server.jar:?]
	at net.minecraft.class_5312.method_28622(class_5312.java:36) ~[intermediary-server.jar:?]
	at net.minecraft.class_2794.method_28508(class_2794.java:309) ~[intermediary-server.jar:?]
	at net.minecraft.class_2794.method_16129(class_2794.java:292) ~[intermediary-server.jar:?]
	at com.dfsek.terra.fabric.generation.FabricChunkGeneratorWrapper.method_16129(FabricChunkGeneratorWrapper.java:133) ~[Terra-fabric-5.3.3-BETA+6027c282-shaded-mapped.jar:?]
	at net.minecraft.class_2806.method_16556(class_2806.java:53) ~[intermediary-server.jar:?]
	at net.minecraft.class_2806.method_12154(class_2806.java:231) ~[intermediary-server.jar:?]
	at net.minecraft.class_3898.method_17225(class_3898.java:555) ~[intermediary-server.jar:?]
	at com.mojang.datafixers.util.Either$Left.map(Either.java:38) ~[intermediary-server.jar:?]
	at net.minecraft.class_3898.method_17224(class_3898.java:549) ~[intermediary-server.jar:?]
	at java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1146) ~[?:?]
	... 11 more

Additional details

latest.log

possibly related to #211