Terra (Fabric/Forge/Paper)

Terra (Fabric/Forge/Paper)

74.2k Downloads

Export command should include entities & NBT data

KaspianDev opened this issue ยท 7 comments

commented

Pre-Issue Checklist

  • I have checked that I am on the latest version of Terra.
  • I have searched the github issue tracker for similar issues, including closed ones.
  • I have made sure that this is not a bug with another mod or plugin, and it is Terra that is causing the issue.
  • I have checked that this is an issue with Terra and not an issue with the pack I am using.
  • I have attached a copy of the latest.log file
  • I have filled out and provided all the appropriate information.

Environment

Name Value
Terra Version 5.4.1
Platform / Platform Version Purpur
Any External Plugins or Mods Oraxen
Terra Packs In Use Default
Terra Addons In Use None

Issue Description

When using worldedit wand and trying to save structure with /terra structure export the item frames don't save.

Steps to reproduce

  1. Make a worldedit selection of structure with item frames
  2. Run /terra structure export command
  3. Check the generated file, it doesnt contain any info about item frame.

Expected behavior

Actual behavior

Full stacktrace

Exception Stacktrace

There isn't anything printing in the console, the command just runs fine.

Additional details

By the way maybe it matters, my item frames are invisible.

Image of original structure:
obraz
Red wool is where i used wand

After exporting:
obraz

I guess you could just save info about the item frame.

commented

item frames probably use nbt data, so this is a certified bukkit moment

commented

Item frames are entities. We should have the export command insert entity functions in the exported scripts, as well as store block & entity NBT data using the nbt function coming in 6.0

of course, the latter would not be available on Bukkit, so on Bukkit it'd just be an empty item frame

commented

I've seen it in some custom structure plugins

commented

@kacperleague9 the problem is, we want to avoid any NMS usage for bukkit because, well, bukkit.

commented

what about nms addon

commented

Well, we want to avoid NMS in the main plugin as much as possible. Because NMS is bad for a variety of reasons. So, the NMS addon is ""not officially supported"", even though it's also by us.
The reason being, NMS can be hard to support. Also, I'm pretty sure the NMS addon throw exceptions lol

commented

export command no longer exists. For static structures like that, use the Sponge Schematic addon.