TerraFirmaCraft

TerraFirmaCraft

Mods
2M Downloads

Old animal food config file prevents Zebu and other newish animals from familiarizing or eating grain

agilmore2 opened this issue ยท 4 comments

commented

To Reproduce
Have an older TFC install before animal_food_data.json was updated with new animals.
Find Zebu in world. Usually somewhere hot.
Attempt to feed them grain.

Reproduce with:

  • TFC Version: build 176 with old config file
  • JEI and WorldEdit mods were present while testing.

Confirmed that Zebu will eat and familiarize if the new config file is present.

commented

Seeing as we have a new system for this now and we're not revisiting this issue

commented

I've seen quite a few complaints about Zebu, parrots, grouse etc. not eating.

commented

Is there any way to fix this besides autodeleting?

commented

Not particularly. Notice our ore gen loading has some differences to the two beneath it

TerraFirmaCraft/src/main/java/net/dries007/tfc/util/json/JsonConfigRegistry.java

Lines 53 to 75 in 0029a01

if (ConfigTFC.General.OVERRIDES.forceDefaultOreGenFile)
{
// Create default vein file
try
{
File defaultFile = new File(tfcConfigDir, "ore_spawn_data.json");
if (defaultFile.exists())
{
// Back up the file, in case of illiteracy
FileUtils.copyFile(defaultFile, new File(defaultFile.getPath() + ".old"));
// And replace the contents
FileUtils.copyInputStreamToFile(Objects.requireNonNull(JsonConfigRegistry.class.getClassLoader().getResourceAsStream(DEFAULT_ORE_SPAWN)), defaultFile);
}
else if (defaultFile.createNewFile())
{
FileUtils.copyInputStreamToFile(Objects.requireNonNull(JsonConfigRegistry.class.getClassLoader().getResourceAsStream(DEFAULT_ORE_SPAWN)), defaultFile);
}
}
catch (IOException e)
{
throw new Error("Problem creating default ore vein config file.", e);
}
}

And in other news, I am beyond ready for this to die in a fire along with everything else that just fails to be a consideration due to datapacks. But it's not particularly a bug, it's the same issue with ore veins.