TerraFirmaCraft

TerraFirmaCraft

2M Downloads

TFC Copper does not integrate into Forge tags despite seemingly having a forge tag

FabioTheTurtle opened this issue ยท 7 comments

commented

Among the copper ingot metadata is the tag "tag:items:forge:ingots:copper", which should allow it to be accessed by other mods as a generic copper ingot, which doesn't seem to work.

Brass, Zinc and Gold have these similar respective tags and DO allow cross mod compatibility.

commented

Please add labels for 1.18.X

commented

This issue report makes no sense. You're reporting that TFC copper both does and does not have a specific tag. I can resolve the confusion, it does. So rather than reporting something that is plainly impossible; what actual thing are you expecting to happen, what actual problem are you running into with copper ingots specifically. In other words, please define "which doesn't seem to work.".

As is; the issue is resolved by it's own description; copper ingots do tag themselves as forge:ingots/copper

commented

You have still failed to articulate an actual problem and are just talking nonsense at this point. Please make an example of a single actual crafting recipe which you would expect to work with a single actual other mod that doesn't when you use this mod with TFC.

commented

In other words, please define "which doesn't seem to work.".

The problem is that despite the fact that TFC's copper ingots containing the relevant forge tags to allow cross mod compatibility, the "ore dictionary," means that it should be able to be cross compatible and freely used among other mods in crafting recipes, for example (assuming they've been coded to allow universal forge items).
This doesn't work, despite having the tag. The copper ingots are not being accepted by other mods as copper ingots.

What makes me consider that this is a bug, is that, as mentioned in the original post, TFC's Brass, Zinc and Gold also carry the universal forge tags for themselves and as such are able to be freely used across mods.

Logic dictates that the copper ingot should also share this function, but for some reason it is not.

commented

I've clearly explained what's happening, but if you insist I give a full example, then fine. Instead of just saying that "copper can't be used in other mods" I figured I'd give a technical example.

TFC copper is not available to use in Create recipes; it will not recognise them in crafting recipes, such as a pipe, and it won't allow it to be pressed in a machine.
Once again, this is despite the fact that they have the forge tags.

TFC's zinc can be broken into Create's zinc nuggets, and TFC brass can be applied to stripped logs to make casings.
TFC Zinc, Brass and Gold will show in valid crafting recipes when looked up in JEI, but Copper does not.

This image shows Copper containing the forge tags.
2022-11-16_07 58 03

These images show that both coppers do not share the same crafting recipes.
2022-11-16_07 58 39
2022-11-16_07 59 02

These images show Brass containing the forge tags, and the fact that TFC Brass can be used in recipes.
2022-11-16_08 02 24
2022-11-16_08 02 41

These images show Zinc containing the forge tags, and the fact that TFC Zinc can be used in recipes.
2022-11-16_08 03 33
2022-11-16_08 03 55

These images show Gold containing the forge tags, and the fact that TFC Gold can be used in recipes.
2022-11-16_08 04 21
2022-11-16_08 04 38

commented

The tag exists, yes. That is as much as we can do.

TFC copper is not available to use in Create recipes; it will not recognise [sic] them in crafting recipes, such as a pipe, and it won't allow it to be pressed in a machine.

Create does not use the forge:ingots/copper tag. It doesn't matter in the slightest what we do or don't tag it as. The create fluid pipe recipe you show, as an example, requires specifically minecraft:copper. Or here. As opposed to where they accept any forge:ingots/zinc

In other words; I've been asking for a concrete example because you are failing to articulate an actual issue with TFC. We already do use the correct ingot tags, there is nothing wrong with their implementation from our end.

This is already filed as an issue with create (Creators-of-Create/Create#3959) and will be entirely on
them to fix.

commented

Understood.
Thank you, apologies for dragging out this report.