TerraFirmaCraft

TerraFirmaCraft

2M Downloads

Broken enableTimeStopWhenServerEmpty setting

copygirl opened this issue ยท 0 comments

commented

Minecraft: 1.18.2
TerraFirmaCraft: 2.2.29
(We're also running a modified version of ATFC.)

First of all, there seems to be a typo in the setting description:

If true, the gamerule 'doDaylightCycle' will be set to 'true' when no players are online on a server.

When no players are on the server, doDaylightCycle should be (and I believe is) set to false to pause the passage of time.

When disabling this setting, I don't appear to be getting the behavior I'm looking for. First of all when querying /gamerule doDaylightCycle in the server console when everyone is offline, I still get "Gamerule doDaylightCycle is currently set to: false".

Then there's these nonsensical messages in the consoles when players log in and out:

[06:42:23] [Server thread/INFO] [ne.dr.tf.ut.ca.Calendar/]: Forced doDaylightCycle to false as no players are logged in. Will revert to false as soon as a player logs in.
...
[06:42:03] [Server thread/INFO] [ne.dr.tf.ut.ca.CalendarEventHandler/]: Player Logged In - Checking for Calendar Updates.
[06:42:03] [Server thread/INFO] [ne.dr.tf.ut.ca.Calendar/]: Reverted doDaylightCycle to false as players are logged in.

In addition, if I use the console to change the gamerule myself, I get this spammed in the console:

> gamerule doDaylightCycle true
[06:40:42] [Server thread/INFO] [minecraft/DedicatedServer]: Gamerule doDaylightCycle is now set to: true
[06:40:42] [Server thread/WARN] [ne.dr.tf.ut.ca.Calendar/]: World time and Calendar Time are out of sync! Trying to fix...
[06:40:42] [Server thread/INFO] [ne.dr.tf.ut.ca.Calendar/]: Calendar is behind by 6 ticks, jumping calendar time to catch up
[06:40:43] [Server thread/WARN] [ne.dr.tf.ut.ca.Calendar/]: World time and Calendar Time are out of sync! Trying to fix...
[06:40:43] [Server thread/INFO] [ne.dr.tf.ut.ca.Calendar/]: Calendar is behind by 6 ticks, jumping calendar time to catch up
...