TerraFirmaCraft

Hi,

It seems pyrite is not being generated with gold veins.

After some reading the code, in constants.py, the pyrite generation is defined as part of native gold generation for all the igneous rocks using rock categories "['igneous_extrusive', 'igneous_intrusive']" for the spoiler_rocks:

TerraFirmaCraft/resources/constants.py

Line 308 in c3c7850

    
           'normal_native_gold': preset_vein('native_gold', 'cluster', ['igneous_extrusive', 'igneous_intrusive'], 'pyrite', 20, ['igneous_extrusive', 'igneous_intrusive'], preset=NORMAL_S_METAL_ORE),

But at the moment of checking those rocks in vein_ore_blocks in world_gen.py, the rocks categories are not being expanded to all the rock names, so it never generates that spoiler_ore:

TerraFirmaCraft/resources/world_gen.py

Line 982 in c3c7850

if vein.spoiler_ore is not None and rock in vein.spoiler_rocks:

Pyrite is the only being affected right now, cose is the only one using a rock category in "spoiler_rocks". Maybe expanding spoiler_rocks with expand_rocks may be enough to solve it:

TerraFirmaCraft/resources/world_gen.py

Line 1412 in c3c7850

    
           def expand_rocks(rocks_list: List[str], path: Optional[str] = None) -> List[str]:

Cheers!

Nice, i reader a little and saw the todo in the spoiler_rock, i will wait.

Thanks!

It seems it also should affect 1.20:

https://github.com/TerraFirmaCraft/TerraFirmaCraft/blob/b1f2590e2126c57be0f68f857814f799eed903d9/resources/world_gen.py#L1101C27-L1101C28

Yes, this is a known issue, it's not getting fixed in 1.18 due to affecting existing worlds, and is fixed in 1.20 by #2516

Share to