Incompatibility with Valkyrien Skies and Clockwork
NewMajor73nanami opened this issue · 2 comments
As shown in the picture, we encountered an issue when attempting to make TerraFirmaCraft:The Next Generation compatible with Valkyrien Skies and Clockwork mod. We are certain that this is not a rendering issue, as the distorted areas have entities.
We have confirmed that in a Superflat world with Valkyrien Skies and Clockwork mod, the blocks in TFC:TNG is working normally.
We suspect that because TFC mod overloaded the method "creatStructures()" of superclass and "applyBiomeDecoration()" ( in net/dries007/tfc/world/TFCChunkGenerator.java ) to preload, the Valkyrien Skies failed to inject these methods.
Moreover, another method (createReferences()) may also encounter the same issues in the future.
Could you please address this problem? If not, we have to contact with VS team or plan to organize a team to resolve compatibility issues by ourselves. Thank you very much.
"Another mod is writing mixins into the vanilla chunk generator and is incompatible with you overriding these method" is not our problem, it's on them to make their mixins compatible with us.
Could you please address this problem?
You haven't stated a problem.. you've said "hey, you're overriding these methods in chunk generator", and my answer is, yes, and with good reason, and no we can't just remove these overrides, that would be moronic.
If there's an actual issue with TFC presented here, we can look into it. But "don't override these methods" is dumb, my answer to that is "don't mixin into the vanilla chunk generator and expect it to just work automatically with other mods chunk generators".
