TerraFirmaCraft

TerraFirmaCraft

Mods
2M Downloads

Knapping recipes don't display input count in JEI when the knapping type has a >1 input count and the recipe uses a ingredient

alcatrazEscapee opened this issue ยท 0 comments

commented

Only present in modpacks where either knapping recipes, or types are added, potentially both. Specifically this requires:

  • A knapping type with a >1 input count
  • A knapping recipe of that type using an ingredient

In JEI this will display the ingredient of the recipe, but not include the count, as per this line of code:

TerraFirmaCraft/src/main/java/net/dries007/tfc/compat/jei/category/KnappingRecipeCategory.java

Line 102 in 7abb82c

final List<ItemStack> inputs = recipe.getIngredient() != null ? Arrays.asList(recipe.getIngredient().getItems()) : collapse(recipe.getKnappingType().inputItem());

The recipe.getIngredient() != null branch here needs to properly incorporate the result of recipe.getIngredient() and recipe.getKnappingType().inputItem().count() into an ItemStackIngredient, then display that.