`TFCAnimalProperties.isFood` is shadowing (vanilla) `Animal.isFood`
JaisDK opened this issue ยท 3 comments
Hi,
I have an addon for TFC that crashes with a NoSuchMethodError on some systems. Are there any situations where the method isFood is not available? It's not crashing in my dev or test env.
Crash log: https://mclo.gs/A54O1Nu
Here's the classes calling isFood https://github.com/JDKDigital/tfcgroomer/blob/dev-1.20.1/src/main/java/cy/jdkdigital/tfcgroomer/common/block/entity/GroomingStationBlockEntity.java#L80
This is an unfortunate problem where compilation with obfuscation is, seemingly, nondeterministic. What's happening here is in TFC, TFCAnimalProperties.isFood() is shadowing the vanilla method Animal.isFood, and depending on how that compiles (in TFC), it can cause weird situations. As it stands, in the released version of 3.2.13, it compiles to the following:
// TFCAnimal.class
public boolean m_6898_(ItemStack stack) {
return super.m_6898_(stack);
}
// TFCAnimalProperties.class
default boolean m_6898_(ItemStack stack) {
return (this.eatsRottenFood() || !FoodCapability.isRotten(stack)) && Helpers.isItem(stack, this.getFoodTag());
}This is, a problem. It's unfortunately a problem that we can't solve without breaking most addons that interact here, because it would involve a rename of isFood to something like isFoodTFC to avoid the shadowing. It's also a problem that is gone in 1.21 (as the lack of obfuscation at dev time means that the method never has this uncertain, non-deterministic renaming.
If your addon works, at the current time, will entirely depend on what it is being compiled as - yes, the method doesn't exist at runtime because it's being shadowed. Forge will, seemingly, correctly obfuscate references to TFCAnimal::isFood but not TFCAnimalProperties.isFood. You might be able to work around this, although it is a ticking time bomb in our code as it stands.
Would it be safe to copy the contents of isFood and use the methods in there?
public static void tickServer(Level level, BlockPos pos, BlockState state, GroomingStationBlockEntity e) {
if (e.counter-- <= 0 && level instanceof ServerLevel serverLevel) {
e.counter = 1200;
List<ItemStack> stacks = new ArrayList<>();
for (int i = 0; i < e.inventory.getSlots(); i++) {
var stack = e.inventory.getStackInSlot(i);
if (!stack.isEmpty()) {
stacks.add(stack);
}
}
List<Animal> entities = level.getEntitiesOfClass(Animal.class, (new AABB(pos).inflate(e.range, 1d, e.range))).stream().toList();
if (!entities.isEmpty()) {
Player fakePlayer = FakePlayerFactory.get(serverLevel, new GameProfile(PLAYER_UUID, "grooming_station"));
entities.forEach(animal -> {
if (animal instanceof TFCAnimalProperties tfcAnimal) {
for (ItemStack stack : stacks) {
if (!stack.isEmpty() && tfcAnimal.isHungry() && isFood(tfcAnimal, stack)) {
tfcAnimal.eatFood(stack, InteractionHand.MAIN_HAND, fakePlayer);
break;
}
}
}
});
}
}
}
static boolean isFood(TFCAnimalProperties tfcAnimal, ItemStack stack) {
return (tfcAnimal.eatsRottenFood() || !FoodCapability.isRotten(stack)) && Helpers.isItem(stack, tfcAnimal.getFoodTag());
}
