TerraFirmaCraft

TerraFirmaCraft

Mods
3M Downloads

Field guide/ore generation audit

kees- opened this issue · 1 comments

commented

I noticed apparent differences between what rock types ores will generate in, versus what is listed in the field guide, for example-

See cinnabar entry:

TerraFirmaCraft/resources/generate_book.py

Line 206 in b890e45

item_spotlight('tfc:ore/cinnabar', 'Cinnabar', text_contents='Cinnabar is a $(thing)Mineral$() which can be ground in the $(l:mechanics/quern)Quern$() to obtain $(thing)Redstone Dust$(). It can be found in veins deep underground, in $(thing)Quartzite$(), $(thing)Granite$(), $(thing)Phyllite$(), and $(thing)Schist$().').link('tfc:ore/%s' % 'cinnabar').anchor('cinnabar'),

Quartzite, granite, phyllite, schist

vs cinnabar oregen definition:

TerraFirmaCraft/src/main/resources/data/tfc/worldgen/configured_feature/vein/cinnabar.json

Lines 11 to 50 in b890e45

"blocks": [
{
"replace": [
"tfc:rock/raw/quartzite"
],
"with": [
{
"block": "tfc:ore/cinnabar/quartzite"
}
]
},
{
"replace": [
"tfc:rock/raw/phyllite"
],
"with": [
{
"block": "tfc:ore/cinnabar/phyllite"
}
]
},
{
"replace": [
"tfc:rock/raw/gneiss"
],
"with": [
{
"block": "tfc:ore/cinnabar/gneiss"
}
]
},
{
"replace": [
"tfc:rock/raw/schist"
],
"with": [
{
"block": "tfc:ore/cinnabar/schist"
}
]

Quartzite, phyllite, gneiss, schist

I didn't audit any other ores so I don't know if any others are wrong. In this case, if this is a discrepancy, I don't know which is right. It looks like the field guide needs an audit/update for correctness. I am willing to do this if it's an issue, provided I know whether the book or the actual worldgen is correct.

commented

Actually, I went through all the config files and guide text and this is the sole discrepancy.

Ore Ok Guide discrepancy Game discrepancy
Native copper ✅
Native gold ✅
Native silver ✅
Tetrahedrite ✅
Malachite ✅
Cassiterite ✅
Bismuthinite ✅
Garnierite ✅
Hematite ✅
Magnetite ✅
Limonite ✅
Sphalerite ✅
Lignite ✅
Bituminous coal ✅
Kaolinite ✅
Graphite ✅
Cinnabar Granite Gneiss
Cryolite ✅
Saltpeter ✅
Sulfur ✅
Sylvite ✅
Borax ✅
Gypsum ✅
Halite ✅
Emerald ✅
Kimberlite ✅
Lapis lazuli ✅
Amethyst ✅
Opal ✅

No other ore veins have differences between the stated height and rock type spawning.