TerraFirmaCraft

TerraFirmaCraft

Mods
3M Downloads

[1.20.1/3.2.17] BiomeBasedClimateModel Causes Cyclical Call Stack in Rare Cases

Notenoughmail opened this issue ยท 0 comments

commented

Full log: https://mclo.gs/Bo41lfc

Due to the changes introduced in #2963, the default climate model can cause a cyclical call stack of

  • BiomeBasedClimateModel#getRainfall -->
  • Biome#getPrecipitationAt --mixin->
  • Climate#getPrecipitation -->
  • EnvironmentHelpers#isRainingOrSnowing -->
  • WorldTracker#isRaining -->
  • Climate#getRainfall -->
  • BiomeBasedClimateModel#getRainfall

in cases where the player enters a dimension with a biome based climate while the level is currently raining (and presumably the client chunk cache hasn't been populated, to hazard a guess)

I am able to reliably recreate this issue with just TFC and Patchouli and no extra datapacks by setting the weather to rain, waiting until it is visibly raining, and then teleporting to a dimension with a biome based climate model (i.e. the end/nether).