[Crash] PrimalCore and TFC
UnlimatedStone9 opened this issue ยท 7 comments
-
What did you expect to happen?
TFC and PrimalCore to launch together like they used to. -
What actually happened instead (i.e. what was the bug)
Game crashed during launch.
https://paste.dimdev.org/oxofigacox.mccrash
To Reproduce
Install both PrimalCore version 1.12.2-0.6.105 and TerraFirmaCraft 1.12.2-0.23.2.70
toggling B:REPLACE_VANILLA_TORCHES=true to false in PrimalCore fixes the crash with TFC
Forge: 14.23.5.2838
TFC: 0.26.1.91
PrimalCore: 0.6.105
PrimalCores GitHub: https://github.com/An-Sar/PrimalCore
Both mods worked fine before, version 1.12.2-0.20.2.52 of TerraFirmaCraft had no crash related issues
Entire log please
Nevermind, I think I've found the problem - both TFC and PrimalCore registry replace minecraft:torch. I'm assuming it's primal core's fault for holding around an unused registry object, because I can't find any references to that in TFC. That said, primal core isn't visible source, so I can't actually verify that. This is on them to solve.
An-Sar/PrimalCore#350
That seems unusual to me, given both worked fine, was the Torch changed recently at all? Iirc TFC used its own Torch in older 1.12.2 builds but I could be wrong.
Yes, it was. Yes it did. Doesn't matter if it seems unusual to you, that's what is causing the issue. As for now the ball is in Primal Core's court since I can't see their code.