TerraFirmaCraft

TerraFirmaCraft

2M Downloads

Placing items in a vessel causes a crash

DavidTriphon opened this issue · 7 comments

commented

Describe the bug

  1. What did you expect to happen?

I placed a berry bush in a small vessel in my inventory.
I did not expect the game to crash.

  1. What actually happened instead (i.e. what was the bug)

the game crashed. (stack overflow error)

  1. If it was a crash, upload the full log file (latest.log)

crash on drop:
crash-2019-09-15_11.40.16-server.txt

crash on grab:
crash-2019-09-15_11.44.39-server.txt

  1. If they would help to explain the issue, include screenshots

To Reproduce

  1. Have a small vessel and a berry bush in your inventory.
  2. Open the small vessel.
  3. Grab the berry bush.
  4. Place the berry bush in the vessel -> crash.
  5. Re-open game and same world. The bush is in the vessel.
  6. Open the vessel.
  7. Grab the berry bush -> crash.
  8. Re-open game and same world. The bush is gone.

Meta Info

  • TFC Version: 0.23.8.75
  • Were any other mods included? Can you reproduce it without these other mods?
    JEI, WAILA, JMap
  • If necessary, what other mods (including versions) MUST be present to experience the bug?
    did not test
commented

Putting food in vessels also cause stack overflow.

commented

Putting in a rock causes the crash. I think it's safe to say that interacting with vessel inventory will always causes a crash.

commented

Neither Alcatraz nor myself can reproduce this in a new world in build 75. It must be related to vessels created in older versions.

commented

Don't know if this should be reported fixed or not. I'm running 0.23.8.75 and I was able to use a vessel without the game crashing.
image

image

Closed out of vessel and it was fine, even used 'V' to place it on the ground, picked it back up and opened it, took stuff out and it never crashed. Even tried different colors of em, and crafted one as I had originally spawned one in from JEI. Still no crash, so feexed?

commented

I’m wondering if this is possibly related to large vessels and barrels having their closed state GUI not visible after the blocks are reloaded? Like the visible state got swapped or something between 74 and 75?

commented

It seems to be related to vessels created in older versions. I'm not sure why this is the case, but as the NBT share tag syncing is still not fully tested, until said point I'm going to leave this open. But it won't be getting fixed if it's not an issue in newer versions.

commented

See #395