TerraFirmaCraft

TerraFirmaCraft

2M Downloads

cobblestone no longer fits in small vessels

agilmore2 opened this issue ยท 4 comments

commented

In classic, cobblestone was heavy/very small, and fit inside small vessels:
2019-11-19_21 43 34

In TNG, cobblestone does not fit in small vessels, and is also heavy/very small.

Meta Info

  • TFC Version: build 94
commented

2019-11-19_23 11 22

commented

Vessels are limited by size: < Large and < Heavy. We currently default to very small / heavy for ItemBlocks. To keep the same stack size, this would need to change to Small / Normal, here:

return new ItemSizeHandler(Size.VERY_SMALL, Weight.HEAVY, true);

Any anywhere else that value is hardcoded. Would also need to investigate possible side effects caused by this change (likely none, but possible interaction with other size limited containers)

commented

It does seem strange to me that 4 Light/Tiny rocks can make a Heavy/V.Small cobble block, so Small/Normal makes sense for cobble blocks and maybe raw blocks.

commented

So this was broken in #519 to make the size annotations match Classic. I think the right answer is Medium/Small to match the 32 stack size of Classic while also allowing carrying them in small vessels.