TerraFirmaCraft

TerraFirmaCraft

2M Downloads

Minor issue with ore dictionary

DisasterMoo opened this issue ยท 3 comments

commented

Looks like there's an inconsistency in ore dictionary for small ores and rich/normal/poor ore samples

see TFC-Metallum/TFC-Metallum#23

commented

Check limonite / magnetite / hematite. i think we should change all small ores to be orePigIronSmall (the inconsistency is that small ores use the ore name for ore dict while graded ore uses the metal name) or the the 3 to be oreLimoniteRich / oreMagnetiteRich / oreHematiteRich (same thing for the poor and normal)

commented

We had this discussion a while ago. The resolution was to keep the ore dictionary names from the metal, not the ore, and to use the suffix corresponding to the size. So in this case, small ores should be changed to be named of the metal (oreIronSmall) instead of the individual ores (oreLimoniteSmall, oreHematiteSmall, etc.)

commented

I don't see the issue here? We have four ore piece types: small, poor, normal, and rich, in increasing size, so we use that as a suffix.