TerraFirmaCraft

TerraFirmaCraft

Mods
2M Downloads

Crops should have different temperature ranges

DavidTriphon opened this issue ยท 3 comments

commented

Describe the request

  1. What problem or issue would this enhancement solve?
    TFC Classic had different temperatures that each plant required in order to stay alive or grow. Currently all TNG crops require exactly 5-35C.

  2. Describe the feature itself - what would change, what would happen. In general more detail is good!
    Change the TNG crop temperature values to more closely match those in classic. Classic only cared about minimum ranges, but TNG doesn't make a difference between alive and growing, so there's some leanway to be done.

Meta Info

  • TFC Version: (at time of request)
    0.28.0.110

  • Is this a compatibility feature for other mods? Or a enhancement for TFC alone?
    This is an enhancement for TFC alone.

  • If necessary, what other mods (including versions) would this require?
    none

commented

TNG doesn't make a difference between alive and growing

Yes, it does, or at least should. See

TerraFirmaCraft/src/main/java/net/dries007/tfc/api/types/ICrop.java

Line 33 in 838dd79

boolean isValidConditions(float temperature, float rainfall);
vs

TerraFirmaCraft/src/main/java/net/dries007/tfc/api/types/ICrop.java

Line 42 in 838dd79

boolean isValidForGrowth(float temperature, float rainfall);

commented

Somehow I missed that. But it's unfortunate that the alive parameters aren't explicit. I think that would be an improvement to allow crops to not die with a greater tolerance than 5 degrees.

commented

#749