TerraFirmaCraft

TerraFirmaCraft

2M Downloads

Crucible calls CapabilityItemHeat#addTemp twice per tick

Mithrik opened this issue ยท 2 comments

commented

Describe the bug
When you put an item into the crucible it heats up as fast as it is allowed to, without considering the heat capacity of the item itself. This results in items heating up way faster in the crucible than the forge/blast furnace.

To Reproduce

  1. Fire up a forge with a crucible placed on top.
  2. Place two identical items, one in the forge, the other in the crucible (I'd recommend wrought iron/a type of steel).
  3. Watch the temperature of both items as they rise. The one in the crucible should get hot significantly faster.

Meta Info

  • TFC Version: 0.29.4.119
commented

I don't believe it's ignoring heat capacity, as both machines are calling through to CapabilityItemHeat#addTemp which handles heat capacity, config values, and other calculation related buisness.

However, I think the crucible may just be double-heating each item each tick, as it's called here:


but then also later here, if the item doesn't melt in that tick

commented

Oh, my bad, seems a copy paste derp ๐Ÿ˜›