TerraFirmaCraft

As discussed in my Quiver PR, #901 (comment)
the implementations of isItemValid differ. Time for the Gathering, there can only be one?

Meta Info

TFC Version: build 124

Expect they aren't different...

TerraFirmaCraft/src/main/java/net/dries007/tfc/objects/items/ceramics/ItemSmallVessel.java

Line 391 in 60a058d

public boolean isItemValid(int slot, @Nonnull ItemStack stack)

TerraFirmaCraft/src/main/java/net/dries007/tfc/objects/container/ContainerSmallVessel.java

Line 30 in 60a058d

public boolean isItemValid(int slot, @Nonnull ItemStack stack)

Only because it was changed between when I made the comments on the PR and now, sorry! Glad to see that they agree. Why are there two of them?

…

On Mon, Mar 30, 2020, 08:51 alcatrazEscapee ***@***.***> wrote: Expect they aren't different... https://github.com/TerraFirmaCraft/TerraFirmaCraft/blob/60a058d27865be5f3535c89438e5c209ec44b3d7/src/main/java/net/dries007/tfc/objects/items/ceramics/ItemSmallVessel.java#L391 https://github.com/TerraFirmaCraft/TerraFirmaCraft/blob/60a058d27865be5f3535c89438e5c209ec44b3d7/src/main/java/net/dries007/tfc/objects/container/ContainerSmallVessel.java#L30 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#927 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN3ODQLVVMHTUUU4MOBOJ7LRKCWX3ANCNFSM4LWJPG5Q> .

Yeah, i also found it weird when i was refactoring Size / Weight, forgot to ask if was needed. Seems to be just a cleanup issue (just call the capability instead of duplicating code), and Alc probably already fixed as he put the fixed in dev tag.

Share to