Crash with Immersive Weathering due to conflicting @Redirect mixins
MehVahdJukaar opened this issue · 10 comments
Redirect is unsafe and should almost never be used. In your case here
Known to crash with Immersive Weathering (to which im reporting the same issue) which has a mixin pretty much identical to what you have.
As far as i know block break particles just use whatever tint color is previded at tint index 0 so to not use it simply dont give any color to tint index 0 and use 1 for the block coloring
hm why not just not use tint index 0 so we can get rid of the issue now? is there something I'm missing, it seems to me like the game already easily supports this kind of behavior without the need for that event or that hardcoded check for the matter
This mixin will be replaced with the event added in FabricMC/fabric#3146 in a future release.
Wontfix for 1.19.x, I think. For 1.20, it could be in the next release although if FAPI 0.85.0+1.20.1 breaks on 1.20 then we would need to drop support for 1.20 (I'm guessing this would be pretty much OK).
that didnt answer my question tho :/
The question is moot, since the FAPI feature in question is already released.
I see this should be resolved in the next release of Immersive Weathering for 1.19.2, so my plan is still going to be leaving it as is in Terrestria for 1.19.2. We will release an update for 1.20.x and maybe backport it to 1.19.4 when we have time.
Resolved in 5b4ffc2 but I will leave this issue open until 1.19.2 is also resolved by one of the other parties involved or I have time and decent Internet connectivity to commit a work-around to Terrestria for 1.19.
Immersive Weathering already has a commit in their repository to resolve the conflict, and 1.19.2 remains their primary version. In comparison, we generally aren't making new releases for old versions like 1.19.2. I would prefer to wait until they make a new release to resolve this issue.
Yes, I did make a release relatively recently to improve compatibility with Create in 1.19.2, but the issue was entirely on our end and the fix was trivial to backport. Neither is the case here.
@gniftygnome Did you have some idea how to port to 1.19.2 ? (I think you did it in commit 9821d52) The fix that you make is based fabric API >= 0.85.0, which have ParticleRenderEvents, 1.19.2 fabric API stops in 0.76.1 and don't have this class. Terrestria v5.0.10 says that: "Improve Create mod compatibility.", but I'm staying have errors. This is the first time I've tried to resolve an error in a Minecraft mod, so I'm a little lost, and I'm not familiar with minecraft modding environment.