stack overflow with Modular Item
x4dr opened this issue ยท 1 comments
Bug Report
Since i can't ask in the discord (dont have a phone) i will just assume it is a bug
Observed Behaviour
slapping together some mods and trying to start the server results in stack overflow exception because of loop
Crash log:
java.util.concurrent.ExecutionException: java.lang.StackOverflowError at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357) ~[?:1.8.0_282] {} at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908) ~[?:1.8.0_282] {} at net.minecraft.server.Main.main(Main.java:130) ~[?:?] {re:classloading} at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_282] {} at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_282] {} at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_282] {} at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_282] {} at net.minecraftforge.fml.loading.FMLServerLaunchProvider.lambda$launchService$0(FMLServerLaunchProvider.java:51) ~[forge-1.16.5-36.1.1.jar:36.1] {} at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] {re:classloading} at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?] {re:classloading} at net.minecraftforge.server.ServerMain$Runner.runLauncher(ServerMain.java:63) [forge-1.16.5-36.1.1.jar:?] {} at net.minecraftforge.server.ServerMain$Runner.access$100(ServerMain.java:60) [forge-1.16.5-36.1.1.jar:?] {} at net.minecraftforge.server.ServerMain.main(ServerMain.java:57) [forge-1.16.5-36.1.1.jar:?] {} Caused by: java.lang.StackOverflowError at net.minecraft.item.ItemStack.func_77958_k(ItemStack.java:268) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:astralsorcery:add_missing_tag_en chantment_tooltip,xf:fml:astralsorcery:add_enchantment_tooltip,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack,pl:mixin:A,pl:runtimedistcleaner:A} at se.mickelus.tetra.items.modular.ModularItem.setDamage(ModularItem.java:472) ~[tetra:3.6.0] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.item.ItemStack.func_196085_b(ItemStack.java:264) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:astralsorcery:add_missing_tag_e nchantment_tooltip,xf:fml:astralsorcery:add_enchantment_tooltip,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.item.ItemStack.func_77982_d(ItemStack.java:509) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:astralsorcery:add_missing_tag_en chantment_tooltip,xf:fml:astralsorcery:add_enchantment_tooltip,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack,pl:mixin:A,pl:runtimedistcleaner:A} at se.mickelus.tetra.util.NBTHelper.getTag(NBTHelper.java:18) ~[tetra:3.6.0] {re:classloading} at se.mickelus.tetra.items.modular.ModularItem.getIdentifier(ModularItem.java:716) ~[tetra:3.6.0] {re:classloading,pl:runtimedistcleaner:A} at se.mickelus.tetra.items.modular.ModularItem.getDataCacheKey(ModularItem.java:131) ~[tetra:3.6.0] {re:classloading,pl:runtimedistcleaner:A} at se.mickelus.tetra.items.modular.ModularItem.getPropertiesCached(ModularItem.java:1002) ~[tetra:3.6.0] {re:classloading,pl:runtimedistcleaner:A} at se.mickelus.tetra.items.modular.ModularItem.getMaxDamage(ModularItem.java:152) ~[tetra:3.6.0] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.item.ItemStack.func_77958_k(ItemStack.java:268) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:astralsorcery:add_missing_tag_en chantment_tooltip,xf:fml:astralsorcery:add_enchantment_tooltip,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack,pl:mixin:A,pl:runtimedistcleaner:A} at se.mickelus.tetra.items.modular.ModularItem.setDamage(ModularItem.java:472) ~[tetra:3.6.0] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.item.ItemStack.func_196085_b(ItemStack.java:264) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:astralsorcery:add_missing_tag_enchantment_tooltip,xf:fml:astralsorcery:add_enchantment_tooltip,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.item.ItemStack.func_77982_d(ItemStack.java:509) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:astralsorcery:add_missing_tag_enchantment_tooltip,xf:fml:astralsorcery:add_enchantment_tooltip,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack,pl:mixin:A,pl:runtimedistcleaner:A} at se.mickelus.tetra.util.NBTHelper.getTag(NBTHelper.java:18) ~[tetra:3.6.0] {re:classloading} at se.mickelus.tetra.items.modular.ModularItem.getIdentifier(ModularItem.java:716) ~[tetra:3.6.0] {re:classloading,pl:runtimedistcleaner:A} at se.mickelus.tetra.items.modular.ModularItem.getDataCacheKey(ModularItem.java:131) ~[tetra:3.6.0] {re:classloading,pl:runtimedistcleaner:A} at se.mickelus.tetra.items.modular.ModularItem.getPropertiesCached(ModularItem.java:1002) ~[tetra:3.6.0] {re:classloading,pl:runtimedistcleaner:A} at se.mickelus.tetra.items.modular.ModularItem.getMaxDamage(ModularItem.java:152) ~[tetra:3.6.0] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.item.ItemStack.func_77958_k(ItemStack.java:268) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:astralsorcery:add_missing_tag_enchantment_tooltip,xf:fml:astralsorcery:add_enchantment_tooltip,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack,pl:mixin:A,pl:runtimedistcleaner:A} at se.mickelus.tetra.items.modular.ModularItem.setDamage(ModularItem.java:472) ~[tetra:3.6.0] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.item.ItemStack.func_196085_b(ItemStack.java:264) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:astralsorcery:add_missing_tag_enchantment_tooltip,xf:fml:astralsorcery:add_enchantment_tooltip,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.item.ItemStack.func_77982_d(ItemStack.java:509) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:astralsorcery:add_missing_tag_enchantment_tooltip,xf:fml:astralsorcery:add_enchantment_tooltip,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack,pl:mixin:A,pl:runtimedistcleaner:A} at se.mickelus.tetra.util.NBTHelper.getTag(NBTHelper.java:18) ~[tetra:3.6.0] {re:classloading} at se.mickelus.tetra.items.modular.ModularItem.getIdentifier(ModularItem.java:716) ~[tetra:3.6.0] {re:classloading,pl:runtimedistcleaner:A} at se.mickelus.tetra.items.modular.ModularItem.getDataCacheKey(ModularItem.java:131) ~[tetra:3.6.0] {re:classloading,pl:runtimedistcleaner:A} at se.mickelus.tetra.items.modular.ModularItem.getPropertiesCached(ModularItem.java:1002) ~[tetra:3.6.0] {re:classloading,pl:runtimedistcleaner:A} at se.mickelus.tetra.items.modular.ModularItem.getMaxDamage(ModularItem.java:152) ~[tetra:3.6.0] {re:classloading,pl:runtimedistcleaner:A} [...]
Expected Behaviour
no infinite recursion
Minimal setup needed to reproduce
just wanted to make sure on discord if i misconfigured something as i dont have a lot of time, but since i dont have a phone i am forbidden from posting there, so i dont have a minimal setup and have not reproduced it in any other form. But looking at the exception it seems like infinite recursion ... which should be findable without much else
- Forge version: forge-1.16.5-36.1.1.jar
- Tetra version: tetra-1.16.4-3.6.0.jar
- Tetra configuration: default
- Other mods: around 194, but the relevant one seems to be astralsorcery-1.16.4-1.13.9.jar
Steps to reproduce
actual:
download ftb presents direwolf20 1.16 version 1.6.0
upgrade to 1.6.1
add and remove some mods, update all available mods to current versions
upgrade forge version
java -jar forge.1.16.5-36.1.1.jar
probable:
tetra + astral in forge 36.1.1