Tetra

Tetra

Mods
12M Downloads

[Bug] Lapis+ does not give additional benefit over lapis for tools

peanubnutter opened this issue ยท 2 comments

commented

Observed behaviour

Lapis+ should give 2x intuit, but actually only gives 1x xp-based honing progress which is no different from regular lapis.

Expected behaviour

Lapis+ should give twice the xp-based honing progress as regular lapis.

Steps to reproduce

  1. Create 2 diamond pickaxes, one with lapis+, one with lapis.
  2. Break some coal (enough to be statistically signficant, say 30 with each pickaxe)
  3. Observe that both pickaxes give roughly the same honing progress.

I looked at the code and there seems to be a bug:

The honing progression for tools should be updated to be "xp * intuitLevel":

tetra/src/main/java/se/mickelus/tetra/items/modular/ItemModularHandheld.java

Line 190 in 1a6710e

tickHoningProgression(entity, itemStack, xp);

just like the honing progression for weapons does:

tetra/src/main/java/se/mickelus/tetra/effect/ItemEffectHandler.java

Line 119 in 1e058d2

((IModularItem) itemStack.getItem()).tickHoningProgression(event.getAttackingPlayer(), itemStack, intuitLevel * xp);

Crashlog

No response

Tetra version

1.18 branch

mutil/mGui version

Idk

Forge version

Idk

Other mods

No response

commented

Ow, fixed this a while back!

commented

Oh, weird. I don't see the fix although I checked what I think are the most recent branches. Is it supposed to be in the 1.18 branch?