TFC_PH_Compat Mod Version:

1.1.0

Descriptions of suggestion:

I have installed these mods shown in the picture below:

But after I checked the PH foods in the game, I found that TFC_PH_Compat Mod did not add TFC nutrition values to PH foods, which should be added.


I think it is helpful to report this issue to you, so I post it here.
Thanks for your patient and kindhearted help in advance.

Hey can you add me on Discord to discuss this bug in more detail? my Discord is Lebeg134#3036

I have noticed this issue as well as all PH food has a 21 day decay

Food added by this mod

Food added by PH

Added by me via Craft Tweaker

Lebeg134#3036

I have sent my Discord adding request to you.
My Discord ID is Project PH03-nix#5759 .

Can you guys check out a few thing for me? Does tfc-ph_compat uncooked items have nutritional data? (I see drhaber has) Does Minecraft Golden apples have nutritional data? Are tfc potatoes heatable in fireplaces? and is sweetpotato heatable in fireplaces?

uncooked items have data, Minecraft Golden apples has data, tfc potatoes is heatable, sweetpotato too
ONLY Pam's foods HAVE NO nutritional data.

Can confirm:
tfc-ph_compat uncooked items have nutritional data
Minecraft Golden apples have nutritional data

tfc potatoes are heatable in the Firepit with two recipes in my instance (I imagine issue 2 plays a part in the two recipes here)

sweetpotato is heatable in the Firepit but has no nutritional data

Edit:
All tfc-ph_compat uncooked items have recipes some heatable in the Firepit some in the Firmalife oven

Edit Edit:

Some Pam's items have illogical recipes (I assume this is an indev thing) or rely on vanilla smelting:
grilled kebab
Cooked Crab
Fried Chicken
Beef wellington

(There are more but I imagine this is not a Bug but instead a pipeline feature)

Dev build → issue persists

TFC_PH_Compat-1.12.2-1.1.1-dev.jar.zip
I couldn't reproduce the problem on my end but I made a potential fix. Please try out this dev build

Testing now...

By the way I couldn't find those illogical recipes. Cooked crabs rely on vanilla smelting because I didn't modify the recipe because crabs aren't obtainable in TFC as far as I know.

Beef wellington and the others have normal recipes in my mod maybe there's an incomplete craft tweaker script somewhere which is overriding some stuff I made

Oh I meant like beef wellington has no uncooked version that needs to then be cooked
The recipe you have above is the same as mine

Crabs -> makes sense

grilled kebab → doesn't use the grill
Fried chicken -> is simply crafted

Oh yes I haven't done thoose yet.
How is the potencial patch?

still loading it is a very large pack ~300 mods

Reduced the list again

Issue persists

Edit: using version TFC_PH_Compat-1.12.2-1.1.0.jar and the same mod list issue does not exist

Removing TFCStorage-1.0.7.jar (common mod between RisingInIris2017 and I) and using TFC_PH_Compat-1.12.2-1.1.0.jar with this list

issue persists

I made another potential fix. Could you try this out as well? ( I still couldn't reproduce the problem even with different forge versions)
TFC_PH_Compat-1.12.2-1.1.1-dev2.jar.zip

what forge version are you on? try using 14.23.5.2847

I have been using 14.23.5.2855
TFC_PH_Compat-1.12.2-1.1.1-dev2.jar

I switched to the version you recommended 14.23.5.2847 used the below list and issue still persists

I think I finally did it! @RisingInIris2017 helped me to reproduce the problem on my machine and I've indentified a problem and fixed it. @drhaber Could you try it out as well?
TFC_PH_Compat-1.12.2-1.1.1-dev3.jar.zip
I don't want to push out the update if it didn't fix all of the bugs mentioned in this issue.

Dev3 did not seem to fix the issue

Could you send over your modlist to download? or give me some logs? maybe I can find something.

Edit: oh and you need to use firmalife 3.0 for the dev3 patch because I updated the compatibility

Mod List You will have to request access please include your Github handle in the comment if you can

2021-03-30-2.log.gz
2021-03-30-3.log.gz
debug-2.log.gz
debug.log
latest.log

Edit: testing with Frimalife 3.1 - issue persists

How did you reproduce the issue? I wonder if that can shed some light on what makes my system/configuration/pack unique

I've sent a request for the google drive.

@RisingInIris2017 sent over his mods folder and that reproduced the issue on my machine, then I found why fooddata were not added to the CustomFoods (it had to to with an Enum initializing before Harvestcraft items were defined) I implemented a check for the pre initialization to be finished in order to solve this.

Something Interesting I've noticed in your case is that for my mod your log states that the jar file is not a mod file which is wierd.

Load order Def makes sense to me as being part of the problem

I should have been able to successfully above the file request

huh, just noticed that too, the mod is not loading at all even when I change the name to TFC_PH_Compat-1.12.2-1.1.1-dev.jar

FML has found a non-mod file TFC_PH_Compat-1.12.2-1.1.1-dev.jar in your mods directory. It will now be injected into your classpath. This could severe stability issues, it should be removed if possible.

I think I know what the problem was on your end. My mod didn't load at all with the modlist you provided to me. I fixed it by renaming the jar file to TFC_PH_Compat-1.12.2-1.1.1-dev.jar from TFC_PH_Compat-1.12.2-1.1.1-dev3.jar I export the dev builds as ...-dev only renamed them in order to distinguish them while you guys debug it. This shouldn't be a problem when I normally release the new version. After fixed the mentioned issue and upgrading to firmalife 3.0 the issue was fixed for me. Could you also test this for me? (Thanks for the help so far btw, I really appreciate it)

I'll close this Issue as the original bug reported was fixed and open a new issue with the mod not registering sometimes