Thaumcraft Fix

Thaumcraft Fix

58.2k Downloads

Server Crash using Salis on Thaumic Isorropia's Curative Vat

Satvn opened this issue ยท 10 comments

commented

The recent patch in version 1.1.3 to fix the issue listed here #75 has caused the formation of the curative vat from thaumic Isorropia to crash the server, similarly to the crafting table it is formed by salis being clicked on it, and downgrading to version 1.1.2 stops this issue occurring

This was tested on the 1.12.2 pack, the issue is not present on the mods noted in the previous issue report, and running the latest version the 1.12.2 pack offers but with the downgraded ThaumFix resolves the issue.

crash-2025-04-26_10.31.46-server.txt

this is the log produced, on the same server/relevant mods as the previous issue report

Im unsure of whether this will need to be fixed on Isorropia's end or yours, but due to it being caused by the recent changes to this mod have reported it here

commented

From recently testing the newest version of Isorropia, the fixed posed by @TheCodex6824 seems to have resolved the formation of the vat crashing the server, thank you both for your help on fixing this problem, though @KELETU66666 another one of your mods, advanced alchemical furnace (this) suffers the same issue, would it be possible to push an update with a similar fix to this mod in order to fully resolve crash related conflicts with these mods?

commented

The Server uses spongeforge on spongeforge-1.12.2-2838-7.4.8-RC4142

Other versions of mods of relevance are:

Sledgehammer-1.12.2-2.0.26-sponge Thaumcraft-1.12.2-6.1.BETA26 ThaumcraftFix-1.12.2-1.1.4 (downgrading to 1.1.2 which does not include the workbench fix is what resolves the crash) isorropia-1.12.2-kedition-1.1.1.jar

pls use vanilla server or "mohist" or "catserver"

commented

From when I was looking at the original issue, I noticed that the Sponge code relies on the Block reporting accurate TileEntity information. If the block says it should have a TileEntity but there isn't one already in the world, it will crash like that. @KELETU66666, I see this method returns a TileEntity for meta values 1-3, but I'm guessing 0 is a valid metadata used for some state. Since the block implements ITileEntityProvider, the default implementation of hasTileEntity will always return true. Does overriding hasTileEntity to return false for metadata 0 (and any other state that doesn't actually have a TileEntity) fix this issue?

commented

which server core are you used :) ?

commented

hmmmm, lemme see....

commented

The Server uses spongeforge on spongeforge-1.12.2-2838-7.4.8-RC4142

Other versions of mods of relevance are:

Sledgehammer-1.12.2-2.0.26-sponge
Thaumcraft-1.12.2-6.1.BETA26
ThaumcraftFix-1.12.2-1.1.4 (downgrading to 1.1.2 which does not include the workbench fix is what resolves the crash)
isorropia-1.12.2-kedition-1.1.1.jar

commented

The Server uses spongeforge on spongeforge-1.12.2-2838-7.4.8-RC4142
Other versions of mods of relevance are:
Sledgehammer-1.12.2-2.0.26-sponge Thaumcraft-1.12.2-6.1.BETA26 ThaumcraftFix-1.12.2-1.1.4 (downgrading to 1.1.2 which does not include the workbench fix is what resolves the crash) isorropia-1.12.2-kedition-1.1.1.jar

pls use vanilla server or "mohist" or "catserver"

We've (Satvn and myself) been hosting this popular modpack using SpongeForge since 2019 and overhauling the server stack would not be feasible at this point. We're greatful for Thaumcraftfix 1.1.4 having resolved #75, and we hope that this new issue that is likely a result of those fixes, can also be worked out.

commented

From when I was looking at the original issue, I noticed that the Sponge code relies on the Block reporting accurate TileEntity information. If the block says it should have a TileEntity but there isn't one already in the world, it will crash like that. @KELETU66666, I see this method returns a TileEntity for meta values 1-3, but I'm guessing 0 is a valid metadata used for some state. Since the block implements ITileEntityProvider, the default implementation of hasTileEntity will always return true. Does overriding hasTileEntity to return false for metadata 0 (and any other state that doesn't actually have a TileEntity) fix this issue?

lemme see...

commented

Has there been any progress on this by any chance?

commented

Has there been any progress on this by any chance?

As far as I can tell, this is not a ThaumcraftFix bug, and is only now happening because the event was fixed and Sponge crashes if it can't get a TileEntity when it thinks it should see one. I tested the theory I described above and it looked like it fixed the issue, so I opened a pull request.

Note that the PR will fix the crashing, but Sponge is only checking the non-blockstate sensitive version of hasTileEntity so it will now be missing tile information in the snapshot. The consequence of this is that plugins won't have tile data for this block, but it's better than crashing. I consider this to be a Sponge issue, but I don't know if they care since blockstate-sensitive hasTileEntity(IBlockState) is a Forge enhancement rather than vanilla like the normal hasTileEntity(), and it's also 1.12.