Thaumic Augmentation

Thaumic Augmentation

Mods
7M Downloads

Impetus Diffuser + Void Siphon hangs server when siphon is full

oleg-py opened this issue · 2 comments

commented

I ran into this issue where my game server would simply stop updating after a while and only backup restore would work, and with JProfiler I get the following picture on server thread:

изображение

In my in-game setup I have a diffuser near one void siphon that I simply let run for a while without actively pulling items from it. From a quick glance, it seems this loop:

ThaumicAugmentation/src/main/java/thecodex6824/thaumicaugmentation/common/tile/TileImpetusDiffuser.java

Lines 208 to 221 in 47bb709

while (siphon.progress >= 2000) {
ItemStack contained = siphon.getStackInSlot(0);
if (contained.isEmpty() ||
(contained.getItem() == ItemsTC.voidSeed && contained.getCount() < contained.getMaxStackSize())) {
siphon.progress -= 2000;
if (contained.isEmpty())
siphon.setInventorySlotContents(0, new ItemStack(ItemsTC.voidSeed));
else
siphon.setInventorySlotContents(0, new ItemStack(contained.getItem(), contained.getCount() + 1));
sync = true;
}
}

doesn't actually have an exit scenario in a case where there's a full stack of void seeds in the void siphon.

commented

Thanks for reporting this issue, it's quite likely that your point about the while loop is correct so with any luck it should be easy to fix.