Thaumic Augmentation

Thaumic Augmentation

7M Downloads

[Suggestion] Add advanced morphic tool and armor

Robolightning opened this issue ยท 4 comments

commented

The current possibilities of the morphic tool are amazing, but at the moment it has only two uses: decorative and reducing warp from the tool, and this makes it practically useless. It would be great if the morph tool and armor had an advanced version that combined the NBT data of both items (functional and decorative). Enchantments in the final item would be chosen from the strongest of those applied to each item, not combined by level (or combined, but not at twice level, otherwise it's too cheating). In addition, the improved tool was completely removed with the wapr of the functional item. Of course, such tools and armor would have more expensive crafting

commented

The problem with doing something like that is that it can lead to exploit-ish situations very easily. As an example, say 2 items both have an "energy" tag - if the NBT was just combined, then one item could get an energy value that it's really not expecting. Best case scenario, people can cheese it to get energy conversion between mods that doesn't make sense (like magic to RF or something), and worst case things start crashing from weird data being there.

I realize that's a hypothetical example, but the lack of namespacing in NBT does present this problem, and I don't really know a good solution to it.

commented

Maybe blacklist of combining electrical tags will be a good solution?

commented

Or (the simplest solution) take the properties of items (their name, durability, sharpness, attack speed) from one item, and NBT from the second

commented

And enchantments can be combined, for example. (Even unallowable together). The main thing is to combine the level not twice. If only to one level more than the maximum, then it will not be too imbalanced, I think. But no more.