Thaumic Bases Unofficial

hi there, been using and testing and having some issues with certain alchemy stuff: i can create crystals in the crucible for every aspect but not for pannus iter and fames (so far) the essence just stay in the crucible until it starts to go into the air, i can take all the other aspect with the crystals (lets see, from leather, i can take out bestia and stuff) but pannus stays in the crucible. Same with iter and fames... any clue what could be going on?I'm using tc6 beta24 pluss tc addons: your mod, thaumic additions, thaumic pheripery and rustic+ thaumaturgy in case you know any of this could cause the bug.

Maybe this bugs with vanila TC, but i see, if i want solutions - i update addon
Also I will ask for more details (gif, small video, etc.) for the full picture
Sorry that I did not answer earlier!

If you're on it, you should also consider using the AspectRegistryEvent which was added in beta 20, to avoid future incompatibilities...

OOOpps Im looking - thanks =)

@iobiarg

Stop
Can I find out about version my addon @iobiarg ?

It's reproduceable with thaumicbases-3.2.255.2r-ForTC6B21, the latest version from curseforge...

The issue is solved, if you move this line to preinit:

Thaumic-Bases-Unofficial/java/com/rumaruka/tb/core/TBCore.java

Line 117 in 258b646

TBThaumonomicon.insertAspects.call();

But you're still using the old deprecated way to add/remove aspects here (why you should use the new AspectRegistryEvent instead...):

Thaumic-Bases-Unofficial/java/com/rumaruka/tb/init/TBThaumonomicon.java

Lines 447 to 488 in 258b646

    
           private static void appendAspects(String oreDict, AspectList toAdd) 
        
           { 
        
               List<ItemStack> ores = ThaumcraftApiHelper.getOresWithWildCards(oreDict); 
        
               if(toAdd == null) 
        
                   toAdd = new AspectList(); 
        
               if(ores != null && ores.size() > 0) 
        
                   for(ItemStack ore : ores) 
        
                       try 
        
                       { 
        
                           ItemStack oc = ore.copy(); 
        
                           oc.setCount(1); 
        
                           appendAspects(oc, toAdd); 
        
                       } catch(Exception oc) 
        
                       { 
        
                       } 
        
           } 
        
           private static void appendAspects(ItemStack stack, AspectList toAdd) 
        
           { 
        
               toAdd = toAdd.copy(); 
        
               // Finds item's aspects, and if there are any, adds them to appended 
        
               // aspects 
        
               { 
        
                   AspectList al = ThaumcraftCraftingManager.getObjectTags(stack); 
        
                   if(al != null) 
        
                       toAdd = toAdd.add(al); 
        
               } 
        
               CommonInternals.objectTags.put(CommonInternals.generateUniqueItemstackId(stack), toAdd); 
        
           } 
        
           private static void removeAspects(ItemStack stack, Aspect... aspects) 
        
           { 
        
               AspectList al = ThaumcraftCraftingManager.getObjectTags(stack); 
        
               if(al != null) 
        
               { 
        
                   for(Aspect a : aspects) 
        
                       al.remove(a); 
        
                   CommonInternals.objectTags.put(CommonInternals.generateUniqueItemstackId(stack), al); 
        
               } 
        
           }

The issue was brought up before on TCs bugtracker: Azanor/thaumcraft-beta#1425

You're registering the aspects to late for Thaumcraft to catch them up, so you've either to move the registering to preinit or register the crucible recipes yourself.
If you're on it, you should also consider using the AspectRegistryEvent which was added in beta 20, to avoid future incompatibilities...

thaumicbases-3.2.255.2r-ForTC6B21 was the file i was using, the last one in curse on your mod page. good luck

Fix
Now You make crystals :3

will wait for the file update, since it hasn't yet showed in curse... probably in a couple of hours if you uploaded it when answered this. thanks

I don't update in curse , because will fix more bugs. Just wait

Fix in new version
Close #7

HI, I still have an issue with 3.2.270.4r that ModTweaker can't find Iter.

HI, I still have an issue with 3.2.270.4r that ModTweaker can't find Iter.

Use ThaumicJei (Iter in Ender Pearl)

And I don`t make ModTweaker Support

well, I would like to add Iter to a custom recipe I have, but I can't use Iter as Thaumic Bases don't register the aspects correctly as it seems?

correct me if I'm wrong and I move this to ModTweaker.

the code in question: https://bitbucket.org/dredhorse/offthebeatenpath/src/master/scripts/artisan_carpenter_worktable.zs
I would have liked to add Iter to the boats, I removed that atm with a workaround.

	private static void appendAspects(String oreDict, AspectList toAdd)
	{
	List<ItemStack> ores = ThaumcraftApiHelper.getOresWithWildCards(oreDict);
	if(toAdd == null)
	toAdd = new AspectList();
	if(ores != null && ores.size() > 0)
	for(ItemStack ore : ores)
	try
	{
	ItemStack oc = ore.copy();
	oc.setCount(1);
	appendAspects(oc, toAdd);
	} catch(Exception oc)
	{
	}
	}

	private static void appendAspects(ItemStack stack, AspectList toAdd)
	{
	toAdd = toAdd.copy();

	// Finds item's aspects, and if there are any, adds them to appended
	// aspects
	{
	AspectList al = ThaumcraftCraftingManager.getObjectTags(stack);
	if(al != null)
	toAdd = toAdd.add(al);
	}

	CommonInternals.objectTags.put(CommonInternals.generateUniqueItemstackId(stack), toAdd);
	}

	private static void removeAspects(ItemStack stack, Aspect... aspects)
	{
	AspectList al = ThaumcraftCraftingManager.getObjectTags(stack);
	if(al != null)
	{
	for(Aspect a : aspects)
	al.remove(a);
	CommonInternals.objectTags.put(CommonInternals.generateUniqueItemstackId(stack), al);
	}
	}

Share to