The Bumblezone (Quilt/Fabric)

The Bumblezone (Quilt/Fabric)

13M Downloads

bee queen gives too many essences

kaboom24 opened this issue ยท 9 comments

commented

whenever you complete the whole questline she gives you three essences not one

commented

Tested singleplayer Neoforge 1.21.1 and Fabric 1.20.1. In both cases, I get 1 Essence of the Bees. Therefore, I need you to give me more info to even go on and what modpack you are using. Otherwise, I'll close this issue report in a week as unreproducable and not enough info to go on.

commented

mc version is 1.20.1 modloader is forge not neoforge singleplayer so I dont think that means server here is the modpack
alexs caves.zip

commented

Using your modpack, I only got 1 Essence of the Bees result
image

I loaded your pack, ran /advancement grant @s through the_bumblezone:the_queens_desire/journeys_end, then right clicked the Bee Queen

Is there anything special you were doing at the time or anything special about your character setup

commented

I am a vampire tier 14 and lord tier 5 but I dont think that makes a diffrence it might just be a bug with my game.

commented

Still gives only 1 when both spam clicking and holding down right click with your modpack. (Speaking of which, spam clicking doesn't make sense to do when holding down right click will trade with less work. Or just dropping the whole itemstack at her feet will trade the entire stack for fastest way)

If you look here:

if (!capability.receivedEssencePrize) {
Vec3 forwardVect = Vec3.directionFromRotation(0, this.getVisualRotationYInDegrees());
Vec3 sideVect = Vec3.directionFromRotation(0, this.getVisualRotationYInDegrees() - 90);
spawnReward(forwardVect, sideVect, ESSENCE_DROP, ItemStack.EMPTY, serverPlayer.getUUID());
capability.receivedEssencePrize = true;

This code runs on right click. receivedEssencePrize is a data point saved in the player's capability data point. If receivedEssencePrize is false because Essence of the Bees was not given to the player yet, it'll give it and then set receivedEssencePrize to true. Then the next time this code runs, this if statement will not run the code inside because receivedEssencePrize is true.

So physically, it can't give the essence of the bees multiple time unless some mod broke the data saving with the capability so it doesn't change receivedEssencePrize to true. Or some mod is running multiple right click code multithreaded in a single click which would be cursed hell and that mod needs to be shot out of a cannon and into the sun.

Either way, I cannot reproduce it and if it is indeed happening for you, it is likely nothing wrong with my code but some other mod and there isn't anything I can do anyway. The capability system is Forge's system and has existed for a long time so any data saving issue within itself for entities would've been found and fixed a long time ago.

commented

WAIT I THINK I FIGURED IT OUT try spam clicking her when the quests are completed I was holding down right click because I was trading at the same time

commented

Please give me more info. What Minecraft version. What modloader. Are you on server on client.

commented

k thanks

commented

Gonna close this on the account of unable to reproduce even with the modpack itself. No one else is reporting or experiencing the bug too oddly enough