The Bumblezone (Quilt/Fabric)

The Bumblezone (Quilt/Fabric)

12M Downloads

bumblezone biomes spawning in the end on a server

benbenlaw opened this issue · 46 comments

commented

on a server the end is filled with bumblezone biomes
image

commented

outer ends and endergetic

commented

What the

commented

Only thing I can think to ask is if the bumble zone biomes are marked as end boomes?

commented

@GiantLuigi4 nope

My biomes are None type which make it stranger. It could be someone's biome source is broken in such a way that they return the wrong int biome ID from the layers which then is resolved to my biome. Commonly caused by people not using the dynamicregistry for biomes in their layers

commented

Yeah even if they were marked as end biomes, I don’t think abnormals core would automatically add them to the biome pool. Pretty sure you need to manually register them for generation with abnormals.

commented

tried chocolate fix as well and it didnt work

commented

The reason chocolate didnt work is because this isn't a biome shuffling issue. That only happens for existing chunks and all a biome shuffling affects is the biome's colors and mob spawns. Not actual biome generation.

I cant reproduce this myself tho with endergetic, outer end, and bumblezone on. Are you able to export your modlist entirely? maybe another mod is needed to be on in order for this conflict to occur?

commented

On the third issue opened relating to this, it does say on servers

commented

https://www.curseforge.com/minecraft/modpacks/skyopolis-4

this mod pack, the end in single player works fine its only on servers

commented

ok so with only those 3 mods bumblezone, Endergetic expansions and outer ends the bug still happens. i have a server up right now if you wanna see first hand

commented

This is sadly not an issue I can fix as I do not touch the end at all. It seems you have an end overhaul mod on that is grabbing Bumblezone’s biomes when it should not be. You should contact whatever end mod you have on to let that dev know their biome source is broken and needs tweaking.

But just wondering, what end mods you have on?

commented

I know what the issue is @GiantLuigi4
They need to override this method and swap the biome parsing inside to use the dynamic register passed in first before trying to resolve the biome with BiomeRegistry.getKeyFromID.
https://github.com/team-abnormals/abnormals-core/blob/601548fd273d8eac75ed56b961343a9559fbe58d/src/main/java/com/minecraftabnormals/abnormals_core/core/mixin/EndBiomeProviderMixin.java#L64

that issue caused me so much pain in bumblezone which is why I fixed it by making my own sampling method

public Biome sample(Registry<Biome> registry, int x, int z) {
int resultBiomeID = ((LayerAccessor)this.BIOME_SAMPLER).bz_getSampler().getValue(x, z);
Biome biome = registry.getByValue(resultBiomeID);
if (biome == null) {
if (SharedConstants.developmentMode) {
throw Util.pauseDevMode(new IllegalStateException("Unknown biome id: " + resultBiomeID));
} else {
RegistryKey<Biome> backupBiomeKey = BiomeRegistry.getKeyFromID(0);
Bumblezone.LOGGER.warn("Unknown biome id: ${}. Will spawn ${} instead.", resultBiomeID, backupBiomeKey.getLocation());
return registry.getValueForKey(backupBiomeKey);
}
} else {
return biome;
}
}

commented

No I believe you. I just cant seem to make the bug happen on my own server which is weird. Bugs that only occur randomly is a pain to debug. Hopefully Abnormal Core can figure out the cause
image

commented

its super strange, the outer ends biomes and the endergetic biomes do not spawn

commented

however these do
image

commented

Looks like bagel linked you a ATM6 post about Forge updating and all. What version of Forge are you using for the server?

commented

36.0.39 i can try updating it

commented

Hmm. Your forge version isnt the issue then. And you are making a new world to test the end each time right?

commented

yep, second normal world has outer ends but not endergetic?

commented

Here's a long shot. No idea if this will work but lets give it a try. Delete your config folder on the server so that it resets back to defaults. Maybe a broken config is doing this?

commented

of the bumblezone or all of them

commented

All the configs. You can move the entire config folder to a different place as temporary storage if you dont want to nuke it entirely

commented

ok

commented

so i did have a default config for the bumble zone

commented

but everything removed still happening

commented

Dang. That was my last suggestion. I got nothing now. Wtf is going on?

I’m curious tho, if you swap Bumblezone for The Undergarden mod, does The Undergarden biomes spawn in the end instead of bumblezone’s?

commented

do you want me to test lol?

commented

image

commented

#56 (comment) Those things are not a biome, they just generate sometimes

commented

You can test if you want but I think you did more than enough work already on this lol. Still, it’s annoying I can’t get it to happen myself.

commented

but they still can be found without the bumblezone mod installed, those commands work

commented

If you were to make a vanilla worldgen datapack which just adds a single biome, and use it on server with just outer end, abnormals core, and endergetic, would the same thing occur?

commented

here's a datapack that has 60+ new biomes (I just took the vanilla worldgen pack and change the minecraft folder to custom so now it is "custom:badlands" and all to make new biomes)
testworldgenpack.zip

commented

where does it go inside the worlds data pack?

commented

image
working???
image

commented

Just checked and the modpack is indeed using the latest abnormals core, endergetic, and bumblezone. Outer end is 4 versions behind but i doubt the issue is caused by that.

Where are you running the server on? Some places like Mohist is know to wreck mods

commented

bisect hosting is the main server but im testing by running a server off home pc

commented

Ok so server is fine

commented

Wack issue you got here

commented

This is the absolutely last thing I can think of. Try this bumblezone jar. I registered my biomes at mod startup with dummy biomes and the json overrides it later. This jar disables that dummy biome creation and registering.
the_bumblezone-1.16.5-2.2.16b.zip

If this jar work, then something in abnormals isn't working properly I think for code biomes being overriden by json biomes. Which is a problem as some people do this to make json biomes spawn in the overworld with forge's BiomeManager hook. And of course, people also use datapacks too to override biomes.

If this jar doesnt work, I'm am gonna get a drink of water and walk away from this cursed issue report lmao

commented

trying now really hopeing it works haha

commented

well well well its working

commented

i deleted the end and added the updated mod and its also working on the server as well

commented

yep then it's a registry issue in abnormal's end biome provider layer most likely. Issue probably would occur with many other mods that uses dummy biomes to spawn json biomes in the overworld.

commented

image
the new generation in the box overridding the old map seems all good thanks :)

commented

Closing now as latest Abnormals Core update has fixed the issue!