The Erebus

The Erebus

16M Downloads

Erebus spawner casting without check, crashes Advanced Rocketry

brandonjohnson21 opened this issue ยท 0 comments

commented

WorldProviderErebus provider = (WorldProviderErebus) world.provider;

An assumption is made that the world provider will be of class WorldProvider or WorldProviderErebus and be able to be casted, however, a cast here is impossible on another subclass of WorldProvider. There should be an instanceof check before casting.

partial log containing crash
https://paste.ee/p/kow9j

I believe this is due to advanced rocketry turning the Erebus dimension into a planet. I am aware the underlying issue is theirs, but this check could alleviate some issues with crashing, at least