The Mighty Architect

The Mighty Architect

9M Downloads

[1.14.4] Mod conflict with camera mod missing gui.

ProsperCraft opened this issue · 7 comments

commented

https://youtu.be/ksHPwdChXFs
One of my players found this and made a video for us.

If the camera mod is in the pack the bottom middle gui is missing, this explains why so many players were getting stuck in the architect mode :)

[1.14.4] Camera Mod 1.4.3
mightyarchitect-mc1.14.4_v0.4.5.jar
commented

Nice, well done discovering that!
Were there any messages in the logs?
Camera mod has its intellectual property protected, troubleshooting might get a little tricky here.

What's interesting is that the Menu works, until the blueprint shader kicks in.

commented
commented

Thank you, this will help immensely.
A few things are to notice right away - the mods use similar techniques and therefore essentially override each others behavior.

  • The callback for scrolling is only granted to the mod loaded last. This is due to the workarounds we had to set up until forge ports the proper ScrollEvent. Relevant lines:
  • The active shader used in the game gets set by both mods simultaneously. TMA and Camera will constantly fight over it. Further testing showed that both TMA and Camera break vanilla's use for the shader system (Spectating an Entity). Relevant Lines:

As for the problems this issue was referring to initially, I haven't yet found a specific cause.
TMA messing with the active shader could possibly cause Camera to cancel RenderGameOverlayEvent, which then causes the menu to disappear until the shader is inactive again.

I'm sure henkelmax has a better understanding, would be interesting to hear their thoughts on this.
Cheers!~

commented

I think the best solution for the scroll issue would be a pull request for forge.
I already did create a scroll event, but never made a PR.
Somehow I lost the code but it shouldn't be that hard to do this again.

For the shader issue I have to look into it a little more.

commented

So I surrounded the resetting of the shader with an if to prevent it being fired everytime:

https://github.com/henkelmax/camera/blob/2ecf39ebcc3ba4f8f7b199fc0fec4c0995e56d2d/src/main/java/de/maxhenkel/camera/ClientEvents.java#L209-L212

This should fix my mod fighting over TMAs setting of the shader...

commented

Most of this should be Resolved in 0.4.6

  • No more Shader fighting from TMA's side.
  • The Menus are now rendered in the overlay phase that Camera skips when running its rendering logic.
  • For Scrolling we'll have to wait a bit longer. I saw a promising PR waiting for about a week now.

Thanks again for the help, and feel free to re-open.