The Spice of Life

The Spice of Life

16M Downloads

[1.10.2] Lunchbox dupe (server side)

xSparky911x opened this issue · 11 comments

commented

In a multiplayer server, when scrolling food from the Lunchbox the game does a temporary freeze and kicks you from the server but does not crash the game. When you join back in you have an extra food item in your inventory and still the same one in the Lunchbox. Not sure if this is caused by Spice of Life or Inventory Sorter based on the log. Does not seem to happen in single player

Forge: 2221
Inventory Sorter: 0.10.5+46
The Spice of Life: 1.3.7

commented

Any chance you could post the log (or just the stacktrace of the error)?

EDIT: Nevermind, found it linked in the Inventory Sorter issue (cpw/inventorysorter#34): http://pastebin.com/PhMyJS4L

commented

It's unclear to me why the malfunctioning code is being executed, as it should be skipped on the server. The code in question:

if (FMLCommonHandler.instance().getEffectiveSide() == Side.CLIENT)
{
	findMatchingClientItemStack();
}
commented

I am unable to reproduce this locally--the code posted above is working as expected for me.

commented

Yeah, was testing it on a server, still no luck. Something really strange has to be happening because there's no way FMLCommonHandler.instance().getEffectiveSide() should be Side.CLIENT on a server as far as I know.

commented

Hmm wonder what I should do lol. Does Inventory sorter have anything to do with it?

commented

I'm not sure. If you can trigger the error consistently, try putting this version of Inventory Sorter on your server and see if that fixes it:

inventorysorter-1.10.2-0.10.5+test.jar

commented

ok will install it right away and reboot the server. The error is consistant for me and a fellow player as of now

commented

Ok that version fixed it. Going back to the old one now to see if error returns

commented

Confirmed. Version 0.10.5+46 will kick me when scrolling food from the Lunchbox as well as the Lunchbag

commented

Alright, thanks for the confirmation. Will submit a pull request to Inventory Sorter with the fix.

commented

And thank you for the fast fix even though it was someone else's mod :) I am using your mod in my Apocalyptic pack and it fits very well. Keep up the awesome work!